Sass compile error while customizing about frow HOT 15 CLOSED

Thanks, investigating a little tonight, but probably headed to bed soon.

from frow.

Are you saying you're trying to pass in a variable to customize something, causing that error? Or that the error is just happening out of the box?

from frow.

I was trying to disable form and button elements through _variables.sass. but getting that compile error. It is perfectly working in the version 3.3.2

from frow.

Thanks, yeah we just switched to using "math" because the old division method is deprecated in the new Sass. What version of Sass are you on, and is it dart sass?

from frow.

Thanks, yeah we just switched to using "math" because the old division method is deprecated in the new Sass. What version of Sass are you on, and is it dart-sass?

I was on 3.3.2 and it was dart-sass and still working perfectly while doing customization/compile. But now I'm trying to move to the latest version. :)

from frow.

Note: I'm using VS code with an extension called Live sass compiler.

from frow.

Sorry I meant which version of Sass are you on? I'm going to debug via the latest version of Sass, 1.41.

from frow.

Hmmm, I just successfully disabled the form and button styling by passing in:

$frow-enable-buttons: false
$frow-enable-forms: false

before loading Frow.

I'm gonna keep trying to reproduce the issue. Is your code open source by chance on a repo? It might just be an out of date version of Sass, but I'm going to keep trying to reproduce.

from frow.

Yeah! Reproduced it by falling back to old versions of Sass. I'm gonna try to narrow down the minimum version needed.

from frow.

Ok, so you need to be running a version of Sass 1.33.0 or greater (latest as of today is 1.41.0). If you're on a version before that, Sass will do the math error.

If you're unable to upgrade to a newer version of Sass, then you're also fine sticking with Frow version 3.3.2. No actual features were added in the jump to 4.0.0. Release notes here.

Unfortunately for me, in an ironic twist, I did release a version 3.3.3 which only included the division fix, as I didn't realize it would be a breaking change for users on older versions of Sass. I should probably look into removing that build from npm, since it apparently can break builds. Apologies.

from frow.

I didn't do any project. It's just a fresh copy of frow version 4.0.0. It might be for older version of Sass. I'm checking everything from the first. Will let you know soon.

from frow.

Ok, so you need to be running a version of Sass 1.33.0 or greater (latest as of today is 1.41.0). If you're on a version before that, Sass will do the math error.

If you're unable to upgrade to a newer version of Sass, then you're also fine sticking with Frow version 3.3.2. No actual features were added in the jump to 4.0.0. Release notes here.

Unfortunately for me, in an ironic twist, I did release a version 3.3.3 which only included the division fix, as I didn't realize it would be a breaking change for users on older versions of Sass. I should probably look into removing that build from npm, since it apparently can break builds. Apologies.

Cool!! Thank you so much for the info. <3

from frow.

I've just released a new version of Frow 3, 3.3.4, I noted your contribution in the release notes. Thanks so much for using Frow and reporting this issue. I'm going to mark this ticket as closed. You can either remain on your current version of Sass and use Frow 3.3.4, or upgrade your Sass to at least version 1.33.0, and then you can use Frow 4.0.0 or greater.

from frow.

I was trying to disable form and button elements through _variables.sass. but getting that compile error. It is perfectly working in the version 3.3.2

Oh and a final word. It could have just been your phrasing, but I'll just point out that you shouldn't actually be changing the _variables.sass file that comes with Frow. You can just make your own variables sass file, and as long as you load it before Frow, your variables will overrule Frows defaults.

So your project would look roughly like this:

@import nhshofficial-variables
@import ~frow

from frow.

I was trying to disable form and button elements through _variables.sass. but getting that compile error. It is perfectly working in the version 3.3.2

Oh and a final word. It could have just been your phrasing, but I'll just point out that you shouldn't actually be changing the _variables.sass file that comes with Frow. You can just make your own variables sass file, and as long as you load it before Frow, your variables will overrule Frows defaults.

So your project would look roughly like this:

@import nhshofficial-variables
@import ~frow

Understood :)
Update: The issue with 4.0.0 has been fixed. It was due to older version of Sass. Thanks a lot. Also, the 3.3.4 is working perfectly with older version of Sass and That's really helpful for v3 users.

from frow.