Comments (1)
I noticed this today.
My patterns are really short [] or null
. I feel like or
should not be a forced line wrap, only a soft one (if line is too long).
Expected:
int Count(List<object> list)
{
switch (list)
{
case [] or null:
return 0;
case [_]:
return 1;
default:
return list.Count;
};
}
Output of 0.27.2:
int Count(List<object> list)
{
switch (list)
{
case []
or null:
return 0;
case [_]:
return 1;
default:
return list.Count;
}
}
If it has to wrap, both options (indented or not) look a little weird.
Personally I think I prefer without indentation (aligned with case
), so that it's not aligned with the case statement. Likewise in switch expressions. Although when there are braces (infrequent?), indented looks good 🤔
// When it has to wrap:
switch (x)
{
case 1
or 2:
case 3:
DoSomething();
break;
}
int i = x switch
{
[]
or null
=> 0,
default => 1,
};
// Although this looks good
switch (x)
{
case 1
or 2:
case 3
or 4:
{
DoSomething();
break;
}
}
from csharpier.
Related Issues (20)
- Usings order HOT 3
- Inconsistent formatting HOT 2
- How can I make CSharpier work with Visual Studio? HOT 26
- Comment between attributes violates SA1515
- Potential new ternary formatting HOT 2
- Formatting for indexer parameters should mostly be the same as for method parameters.
- File with only file scoped namespace + comments gets extra lines HOT 1
- Incorect formatting of ternary expresion with a comment after an interpolated string
- VS 2022 "Ensure there is a csharpier process for ..."
- Switch expression single line broken when preceded by comment
- VSCode not working (probably a dup of #1260) HOT 2
- [Rider] formatting on save not working since 0.28.0
- CSharpier binary not found when dotnet-tools.json is missing, despite CSharpier installed globally
- Formatting of empty collection initializer for huge type
- Configurable indentation/levels for fluent methods
- Rider extension not recognise global csharpier again HOT 2
- Excess empty line in combination of switch expression, value tuple, and pattern matching HOT 2
- Support custom extensions in .editorconfig
- Support custom file extensions with IDE extensions HOT 2
- Bad wrapping and indentation on long switch expression branches matching on tuples
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from csharpier.