Giter VIP home page Giter VIP logo

Comments (1)

jods4 avatar jods4 commented on June 2, 2024 1

I noticed this today.
My patterns are really short [] or null. I feel like or should not be a forced line wrap, only a soft one (if line is too long).

Expected:

int Count(List<object> list)
{
  switch (list)
  {
    case [] or null: 
        return 0;
    case [_]: 
        return 1;
    default:
        return list.Count;
  };
}

Output of 0.27.2:

int Count(List<object> list)
{
    switch (list)
    {
        case []
        or null:
            return 0;
        case [_]:
            return 1;
        default:
            return list.Count;
    }
}

If it has to wrap, both options (indented or not) look a little weird.
Personally I think I prefer without indentation (aligned with case), so that it's not aligned with the case statement. Likewise in switch expressions. Although when there are braces (infrequent?), indented looks good 🤔

// When it has to wrap:
switch (x) 
{
  case 1
  or 2:
  case 3:
    DoSomething();
    break;
}

int i = x switch
{
  []
  or null 
    => 0,
  default => 1,    
};

// Although this looks good
switch (x) 
{
  case 1
    or 2:
  case 3
    or 4:
  {
    DoSomething();
    break;
  }
}

from csharpier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.