Comments (4)
Thanks @djhmateer, pinning to 5.12.4 seems like a sensible idea until we know if there are any cases that are broken by gspread 6.0.0.
Looks like this change occurred here: burnash/gspread@6457676
from auto-archiver.
Pinning is a good decision for now.
Adapting to the new version should not be too hard and require changes only to https://github.com/bellingcat/auto-archiver/blob/main/src/auto_archiver/utils/gworksheet.py
namely
auto-archiver/src/auto_archiver/utils/gworksheet.py
Lines 67 to 68 in 590d3fe
should be
if fresh:
val = self.wks.cell(row, col_index + 1).value
return val if val != "None" else ""
to keep consistency.
I'm not making the changes yet since testing if there were other changes to gspread.worksheet.get_values()
to return "None"
s too. But those are the only 2 places we interact with the gspread.worksheet to read the values.
from auto-archiver.
gspread devs were quick to acknowledge this and there will be a patch in 6.0.1: burnash/gspread#1403
from auto-archiver.
warning stands: do not use gspread 6.0.0, we can fix it at >=6.0.1 after that's released and tested.
from auto-archiver.
Related Issues (20)
- Google drive - shared folders HOT 1
- use https://github.com/webrecorder/warcio.js to avoid extracting media for html file HOT 2
- Selenium headless not working - workaround to force 4.12.0 HOT 2
- x.com urls make work like twitter.com HOT 2
- Facebook archiving HOT 3
- feat: enricher to extract the article/text content from newsarticles HOT 4
- feat: add estimation of explosion time, if applicable to video/audio archived HOT 2
- tiktok_downloader error while installing: subprocess-exited-with-error / metadata-generation-failed HOT 4
- feat: add link to image forensics tools directly HOT 1
- move auth from basic to bearer
- refactor github workflow to trigger on new release rather than tag push
- improve config parsing to accommodate type casting and validation rules HOT 1
- feature: add print to pdf option in screenshot_enricher
- feat: add tagged content to new instagram_api_archiver HOT 1
- fix: recent changes to telethon sessions leave ghost files
- metadata generation failed HOT 5
- Instagram recommended strategies HOT 3
- no _mimetype set for final media html files HOT 2
- pdqhash problem on Pipfile update HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from auto-archiver.