Giter VIP home page Giter VIP logo

Comments (4)

GalenReich avatar GalenReich commented on June 12, 2024 1

Thanks @djhmateer, pinning to 5.12.4 seems like a sensible idea until we know if there are any cases that are broken by gspread 6.0.0.

Looks like this change occurred here: burnash/gspread@6457676

from auto-archiver.

msramalho avatar msramalho commented on June 12, 2024 1

Pinning is a good decision for now.

Adapting to the new version should not be too hard and require changes only to https://github.com/bellingcat/auto-archiver/blob/main/src/auto_archiver/utils/gworksheet.py

namely

if fresh:
return self.wks.cell(row, col_index + 1).value

should be

        if fresh:
            val = self.wks.cell(row, col_index + 1).value
            return val if val != "None" else ""

to keep consistency.

I'm not making the changes yet since testing if there were other changes to gspread.worksheet.get_values() to return "None"s too. But those are the only 2 places we interact with the gspread.worksheet to read the values.

from auto-archiver.

msramalho avatar msramalho commented on June 12, 2024

gspread devs were quick to acknowledge this and there will be a patch in 6.0.1: burnash/gspread#1403

from auto-archiver.

msramalho avatar msramalho commented on June 12, 2024

warning stands: do not use gspread 6.0.0, we can fix it at >=6.0.1 after that's released and tested.

from auto-archiver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.