Errors for commented out imports and exports about destiny HOT 9 CLOSED

@alubbe Nice find!

The current logic utilizes pattern matching to find imports and exports. It should of course ignore commented out lines.

from destiny.

Okay so then ignoring lines with a preceding // is simple, but I'm not sure what the most economic/effient way would be to find out whether you're in a (possible nested) /* ... */ block - how would you resolve that with pattern matching?

from destiny.

Ok so JavaScript does not have nested comments, so it suffices to find the last */ and then scan if there are any /* between that and your current position

from destiny.

or, more economically, find the nearest preceding /* and the see if it has been closed by a */ before your current position - but you probably want to keep track of all of this per file because otherwise you're doing this per line with an import statement

from destiny.

anyways, thanks for this tool - I hope to try it again once it ignores comments (atm our code base is just too large and littered with comments for me to clean up by hand)

from destiny.

@alubbe There are plenty of ways to solve this problem. I'll ping you once it is done. Cheers for the input. 👍

from destiny.

@alubbe This should now be fixed on the next release of destiny.

from destiny.

amazing, thanks!

from destiny.

@alubbe This is now released.

from destiny.