Comments (6)
BenDMyers
commented on July 18, 2024
What makes this tricky is, from what I can tell, banning a commenter for their message within Twitch doesn't seem to fire the onMessageDeleted event (or maybe it does and there's an error somewhere?)
Anyways, if there's any way to delete the message when the user is banned, we should do so, as it breaks users' assumption that "deleting" the message will delete it in the overlay view, too.
from showmy.chat.
KenAKAFrosty
commented on July 18, 2024
I'll have to see what Comfy exposes to us but I'm fairly sure Twitch's API provides ban events (on mobile currently or I'd check for certain). If we listen for that event and then remove all messages with a matching sender, that should suffice, no?
from showmy.chat.
KenAKAFrosty
commented on July 18, 2024
Looked closer at Comfy. I have a hunch we could check onPart event for user metadata, since banning would force them to leave. There may be some sort of boolean flag on the user for 'banned' or similar? Then if so, delete all messages with a matching sender username
from showmy.chat.
BenDMyers
commented on July 18, 2024
I think this issue (still open, at time of writing) on the ComfyJS repo could be helpful: instafluff/ComfyJS#23 — it seems like the tmi.js client does expose a 'ban' event, but ComfyJS isn't yet consuming it.
I think maybe the best path forward for this issue could be contributing an onBan hook to ComfyJS that we could leverage here?
from showmy.chat.
KenAKAFrosty
commented on July 18, 2024
Perfect! I had half a mind to see if it was Comfy not exposing tmi
functionality and here you've already dug into that very thing and even
found a current issue! Id love to work with you to go contribute to Comfy
(plus even if it takes time to get a PR merged, we could still use it in
this codebase in the interim)
…On Wed, Jan 12, 2022, 2:11 PM Ben Myers ***@***.***> wrote:
I think this issue (still open, at time of writing) on the ComfyJS repo
could be helpful: instafluff/ComfyJS#23
<instafluff/ComfyJS#23> — it seems like the
tmi.js client does expose a 'ban' event, but ComfyJS isn't yet consuming
it.
I think maybe the best path forward for this issue could be contributing
an onBan hook to ComfyJS that we could leverage here?
—
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVR4GZ2STO4IWBZV233CZALUVXG7XANCNFSM5LXTREKQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID: <BenDMyers/showmy
.***@***.***>
from showmy.chat.
BenDMyers
commented on July 18, 2024
@KenAKAFrosty Would you be able to look into adding the onBan hook upstream in ComfyJS?
from showmy.chat.
Related Issues (20)
- Improve `showCommands` experience in URL builder HOT 1
- [feature request] Add badge to names HOT 8
- Allow themes to style `/announce` messages HOT 1
- [Docs] Homepage should explain what this is and how to use it more clearly
- Bug: long links are causing scrollbars on the default theme HOT 2
- Document available css custom properties available for developers HOT 1
- [feature request]: Hotdog based theme HOT 1
- Allow config for buffering messages
- Create progress bar for fundraisers HOT 3
- [feature request] Elevated message flag? HOT 1
- Automatic dependency updates HOT 1
- Document all stylehooks a theme can use
- Allow users to bring their own styles HOT 7
- Let users customize themes with URL-encoded styles HOT 3
- Create a guide for integrating with OBS
- Provide textual descriptions for themes in the HTML for accessibility HOT 3
- Testing Discord webhook; please disregard. HOT 2
- [Lint] Disable `no-descending-specificity` Stylelint rule HOT 1
- show latest messages causes lockup
- Remove deletion delay when themes don't animate/transition outgoing messages HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from showmy.chat.