Unable to leverage universal-cookie, react-cookie, and universal-cookie express with NodeNext module resolution about cookies HOT 6 CLOSED

Hi @corbin-mosher ,

The TypeScript types seem to be not working with your tsconfig configuration. I'm trying to dig deeper to find a solution to why, this is very unexpected.

from cookies.

@eXon, yeah, it is very confusing.

I even tried cloning the cookies project and running it through my normal build pattern and I have the same type issue.

The only way I have gotten it to work is to also export Cookies as a named export, not just the default. For some reason, with NodeNext tsconfig there is a struggle with this declared Cookies class, but only when its the default export 🙃

There have been one or two more npm packages that have had similar issues for me with default exports and NodeNext, so I am likely going to just stick with Bundler+ESNext for now and continue using unbuild (rollup) to handle build commands.

I am super curious though to learn what causes this hangup when building and resolving things purely with tsc+tsconfig. My guess is that there is some not very well known "specification" around ESM and types we are missing that has become required with the latest moduleResolution 🤷

from cookies.

@corbin-mosher This is fixed in 7.1.2, let me know if it works for you

from cookies.

@eXon, thanks! Types are working as expected now with NodeNext for moduleResolution in tsconfig.

I really appreciate the quick help.

from cookies.

@eXon, now that I have had time to sit down with this further, it seems to me that the post build script plan might need some alterations.

It is impacting imports of external dependencies as well. For example, in react-cookies the type file for CookieProvider is altered from:

import * as React from 'react';
import Cookies from 'universal-cookie';
import { ReactCookieProps } from './types';
export default class CookiesProvider extends React.Component<ReactCookieProps, any> {
    cookies: Cookies;
    constructor(props: ReactCookieProps);
    render(): React.JSX.Element;
}

to

import * as React from 'react.d.mts';
import Cookies from 'universal-cookie.d.mts';
import { ReactCookieProps } from './types.d.mts';
export default class CookiesProvider extends React.Component<ReactCookieProps, any> {
    cookies: Cookies;
    constructor(props: ReactCookieProps);
    render(): React.JSX.Element;
}

Its possible that the change on line 3 is OK since it is referencing a file directly. But I think the changes on line 1 & 2 would cause issues. Let me know what you think.

from cookies.

@corbin-mosher You're right! I've fixed the regex, let me know if 7.1.4 works

from cookies.