cc-exp-month and cc-exp-year not setting maxlength=2 when type="number" about angular-credit-cards HOT 3 CLOSED

The maxlength attribute IS being set to two (or 4). The issue is that maxlength affects type="string" but not type="number".

Options:

1. Set max="99", min="0" - This is more type="number" friendly. It would still allow for floats (3.1617 would be valid), so the value would need to be rounded on update.
2. Change Readme to reflect that one may use type="text" but not type="number" - Quick fix.. But should be avoided since all input will be numeric

from angular-credit-cards.

This is going to be a docs fix. Unless there's a priority issue the validation key should still be set with type="number" because maxlength handling checks the length of the view value (always a string):

https://github.com/angular/angular.js/blob/master/src/ng/directive/input.js#L2698-L2716

I'll confirm this via a test though. I'm not willing to make the extra effort to reproduce the browser's maxlength behavior (preventing entry and slicing pastes after n characters) for type="number" since creditcards is already going to parse the number properly anyway.

from angular-credit-cards.

Thanks!

from angular-credit-cards.