Giter VIP home page Giter VIP logo

Comments (10)

rcidt avatar rcidt commented on May 22, 2024 1

@benevbright Thanks for looking into this, yes please let me know. I will also give it some thought as well.

from react-navigation-collapsible.

rcidt avatar rcidt commented on May 22, 2024

oct-03-2018 10-17-17

from react-navigation-collapsible.

benevbright avatar benevbright commented on May 22, 2024

Hi, @rcidt
I really appreciate your issue and GIF.
Please let me understand clearly. Did you expect to the tab be hidden too?

If so, showing tab is the way I built this module. (and it's also the way many major apps do)

from react-navigation-collapsible.

benevbright avatar benevbright commented on May 22, 2024

Oh, you have bottom tab too.
It would be great if the module would be able to hide it as well. #28

from react-navigation-collapsible.

rcidt avatar rcidt commented on May 22, 2024

@benevbright This is working just as I expected. I expect the tabs to stay visible at all times, but the Titled Header to be hidden from view as I scroll down.

The only thing that is not working as expected is the "sticky headers". This is a SectionList, so the each "sticky header" should stick to the top of the scrollable area.

In my Gif, if you look carefully you will see two rows, with the following title "Seen" and "Replied". Those are the sticky headers.


I have played around with collapsible source code a bit, maybe it will clarify:

index.js line 20:

const defaultHeaderHeight = Platform.select({ios: 44, android: 56, web: 50});
const defaultTabHeight = 50;
-const safeBounceHeight = Platform.select({ios: 300, android: 100, web: 200});
+const safeBounceHeight = Platform.select({ios: 70, android: 100, web: 200});

index.js line 333:

return (
-       <View style={{flex: 1}}>
+       <View style={{marginTop: 70, flex: 1}}>
         <SafeAreaView style={{flex: 1}} forceInset={{bottom: 'never'}}>

And here is the result:
oct-03-2018 10-57-42
Notice how in the above Gif, the sticky headers do eventually stick to the top scroll area. But as you can see there are a few issues with this.

Hopefully you can shine some light on how to achieve this.

Thanks you for your time

from react-navigation-collapsible.

benevbright avatar benevbright commented on May 22, 2024

Oh, I got it now.
Thanks again for your explanation.
I'll look into it!

from react-navigation-collapsible.

benevbright avatar benevbright commented on May 22, 2024

Hi, I tried to resolve this issue but I don't think I could resolve it easily.
Yes, I was able to reproduce the same behavior.
And as you point out, it's relative with safeBounceHeight.
safeBounceHeight is necessary to prevent the side effect of this module.
I will update you if I find a solution. :)

from react-navigation-collapsible.

benevbright avatar benevbright commented on May 22, 2024

https://github.com/benevbright/react-navigation-collapsible/tree/bug/sectionlist
I created bug/sectionlist branch reproducing bug with SectionList.

from react-navigation-collapsible.

radetsky avatar radetsky commented on May 22, 2024

@rcidt How did you make floating button fixed? I tried to use position absolute, but the screen height is floating too when headers collapsing.

from react-navigation-collapsible.

rcidt avatar rcidt commented on May 22, 2024

@radetsky it is rendered higher up in the component tree. Outside of the list.

from react-navigation-collapsible.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.