Giter VIP home page Giter VIP logo

Comments (10)

paolospag avatar paolospag commented on May 16, 2024 8

Hi @benevbright,
first of all congratulations for your very useful module.

Any updates about RN 3.0 support? The latest version is still in alpha.

from react-navigation-collapsible.

benevbright avatar benevbright commented on May 16, 2024 4

Thanks very much. @z98361
I'll look at it.

from react-navigation-collapsible.

nonotest avatar nonotest commented on May 16, 2024

yep there seems to be some issues for example the header is missing some paddingHeight for me , like 20 and goes to the wrong spot all the time.
not exactly sure of where it comes from.. happy to have a look this weekend if no one does before

from react-navigation-collapsible.

nonotest avatar nonotest commented on May 16, 2024

i think we also need to remove the safeareaview included in this module

from react-navigation-collapsible.

benevbright avatar benevbright commented on May 16, 2024

Yes, I'm updating the work on this PR #50.

from react-navigation-collapsible.

z98361 avatar z98361 commented on May 16, 2024

when using collapsibleCustomHeader appear white background after header
react-navigation: v3.0.5
react-navigation-collapsible: v3.0.0-alpha1
scroll half:

end scroll:

from react-navigation-collapsible.

benevbright avatar benevbright commented on May 16, 2024

Hi, I appreciate your comments.
It's about to be released.
#50

from react-navigation-collapsible.

0x01001 avatar 0x01001 commented on May 16, 2024

when using collapsibleCustomHeader appear white background after header
react-navigation: v3.0.5
react-navigation-collapsible: v3.0.0-alpha1

@benevbright
This issue is not fix

class DefaultHeaderScreen extends Component{ static navigationOptions = { // title: 'Default Header' header: (<View style={{height: 56, justifyContent: 'center', alignItems: 'center', backgroundColor:'green'}}><Text>Header</Text></View>) }; ...

screenshot_1548736319

from react-navigation-collapsible.

benevbright avatar benevbright commented on May 16, 2024

Hi, @0x01001 I appreciate your issue.

Unfortunately, the Custom component header is no longer supported on v3 of this module. It's making some problems especially in transition, and implementation of the Custom component header on react-navigation got worse than v2. I gave up with that, tbh.

from react-navigation-collapsible.

0x01001 avatar 0x01001 commented on May 16, 2024

Hi, @0x01001 I appreciate your issue.

Unfortunately, the Custom component header is no longer supported on v3 of this module. It's making some problems especially in transition, and implementation of the Custom component header on react-navigation got worse than v2. I gave up with that, tbh.

Thanks for help quickly, fixed by using headerLeft or headerRight.

from react-navigation-collapsible.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.