Giter VIP home page Giter VIP logo

Comments (5)

benfred avatar benfred commented on June 16, 2024 1

it looks like libproc is failing to build here w/ fatal error: 'libproc.h' file not found .

This seems to be the same error as andrewdavidmackenzie/libproc-rs#82 .

I just built successfully on my OSX system, but I'm still on Catalina (and on an intel based machine).

from py-spy.

jrabinow avatar jrabinow commented on June 16, 2024

Thanks for linking both issues, I reported my issue upstream along with a patch. I'm not sure how long it'll take to fix or what functionality is included in the libproc library - asking with zero context here, does it make sense to try to remove the dependency on libproc-rs?
If not, it might make sense to close this issue since it looks like the problem is upstream

from py-spy.

benfred avatar benfred commented on June 16, 2024

does it make sense to try to remove the dependency on libproc-rs?

py-spy isn't actually using libproc directly, libproc is being used by the remoteprocess and proc-maps dependencies of py-spy. the remoteprocess dependency is using it to get the exe/cwd https://github.com/benfred/remoteprocess/blob/70509587992eead0fdeb5534125c8ac7db2ce9a8/src/osx/mod.rs#L50-L62 - and proc-maps is using it to get the filename for a region of memory https://github.com/rbspy/proc-maps/blob/6d6fcb987fe663a7232b90a4182feb0dfc7c1f4c/src/mac_maps/mod.rs#L146 .

We could replace it in both cases, but ideally we'd just get it fixed upstream.

from py-spy.

jrabinow avatar jrabinow commented on June 16, 2024

Both libproc-rs and proc-maps have released new versions with the fix

from py-spy.

jrabinow avatar jrabinow commented on June 16, 2024

Hi @benfred would it be possible to release a new version of py-spy including the upstream fix from libproc-rs?

from py-spy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.