Giter VIP home page Giter VIP logo

Comments (16)

benjaminkott avatar benjaminkott commented on September 24, 2024

hey @dwenzel thx for reporting.
Does the style module save the changes? or dont they simply dont show up in the frontend?

from bootstrap_package.

dwenzel avatar dwenzel commented on September 24, 2024

Hi @benjaminkott, thx for caring :)
the style module doesn't save any changes.

Cheers
Dirk

Am 27.06.2014 um 18:35 schrieb Benjamin Kott:

hey @dwenzel thx for reporting.
Does the style module save the changes? or dont they simply dont show up in the frontend?


Reply to this email directly or view it on GitHub.

from bootstrap_package.

timpleton avatar timpleton commented on September 24, 2024

Hi, any news in this issue?
I get the same behavior on a freshly installed TYPO3 6.2.4 with "Introduction Package". A blank install with manually added Bootstrap Package does not save the changes either.
Do you have any hints on what to check? Anything I can help with?

from bootstrap_package.

benjaminkott avatar benjaminkott commented on September 24, 2024

@dwenzel @timpleton hey, i had a look into this issue but i really cannot reproduce this issue - tested this already on multiple environments. we are currently working on an alternative implementation to solve this issue and the hardcoded less issue with multiple installations etc. hove i can provide an update till end of next week.

but in general any help is appreciated - missing features, bugs etc just provide patches if you like.

from bootstrap_package.

timpleton avatar timpleton commented on September 24, 2024

@benjaminkott Hi, I'm not deep enough into it to try patching or bugfixing myself. Which file is it, that should be written when clicking on the "Save"-Button in the style editor? Maybe it's a problem with ACL or file permissions. I want to check this...

from bootstrap_package.

benjaminkott avatar benjaminkott commented on September 24, 2024

@timpleton when you hit the save button the script writes an new less variables file / or updates an existing one that is placed here: typo3conf\ext\bootstrap_package\Resources\Private\Less\Bootstrap-3-1-1\variables.less

from bootstrap_package.

timpleton avatar timpleton commented on September 24, 2024

@benjaminkott I checked permissions on these files. They were all writeable by the webserver.
Is there anything I can do beside turning TYPO3 into debug mode and rising PHPs error logging? Because I do not see any errors in my logs when I click the save button.

from bootstrap_package.

benjaminkott avatar benjaminkott commented on September 24, 2024

Hey @timpleton @dwenzel,
I removed the backendmodule - you can now place less files directly in your typoscript as you do it with normal css files. All bootstrap variables are configurable via typoscript and the less files an now rendered and cached on demand.

bootstrap_package-styling

I will close this issue since the original problem does not exist anymore.

from bootstrap_package.

dwenzel avatar dwenzel commented on September 24, 2024

Hi @benjaminkott,
sounds good for me. I prefer TypoScript settings anyway.
I will have a look at it soon.
Thank you!

from bootstrap_package.

timpleton avatar timpleton commented on September 24, 2024

Hi @benjaminkott,
I just gave it a try. It works like a charme.
Thank you very much.
You should consider uploading this version to TER so the official introduction package can benefit from it too.

from bootstrap_package.

benjaminkott avatar benjaminkott commented on September 24, 2024

Hey @timpleton, as soon i gave it some more tests this can be uploaded to the ter. I want to ensure first that there are no sideeffects and everything works like expected.

from bootstrap_package.

webian avatar webian commented on September 24, 2024

Hi @benjaminkott,
I updated my installation with this commit and your customization of bootstrap (I mean the orange one with Share font) is visible in the FE only after the first hit after a flush of the FE cache:

20140721_205159_610

The next it on any page of the website shows the standard bootstrap css:

20140721_205249_577

Can you give me a hint of a place in the code of this extension where I could start to debug this issue?

Thanks!
ian

from bootstrap_package.

benjaminkott avatar benjaminkott commented on September 24, 2024

@webian i was just running also into this issue and i am currently debugging this behaviour and cleaning things up a bit.

its maybe something here
https://github.com/benjaminkott/bootstrap_package/blob/master/Classes/Hooks/PageRendererRender/PreProcessHook.php

or here
https://github.com/benjaminkott/bootstrap_package/blob/master/Classes/Service/CompileService.php

id just said that this need more testing before i can go into ter ;)

from bootstrap_package.

benjaminkott avatar benjaminkott commented on September 24, 2024

@webian can you try again please - this should now work correctly, at some point the flattenSetup was missing.

from bootstrap_package.

webian avatar webian commented on September 24, 2024

@benjaminkott problem solved for me too... good job! Thanks :)

from bootstrap_package.

benjaminkott avatar benjaminkott commented on September 24, 2024

@webian ok - bootstrap update next then ;)

from bootstrap_package.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.