UncrustifyPlugin selected Group about bbuncrustifyplugin-xcode HOT 9 CLOSED

I finish to improve this request myself :)

now it can support selected group from project navigator.
Even for multiple selection or sub-group, still work well.

here is my code by compare, I can crate a new PR for you

thank you and thank for this great plugin.

from bbuncrustifyplugin-xcode.

That's great. It would be a nice addition.

I tried it but there is actually an issue: if the group has never been opened (triangle to the right), the plugin doesn't see any file inside the folder and the command "Uncrustify selected files" stay disabled. Once the folder has been opened (triangle to the bottom), it works (even if the folder is closed). I had this issue when I played with the navigator tree.

Can you reproduce this issue?

from bbuncrustifyplugin-xcode.

wow, it seem like a big problem for never un-opened group......how to get them?

from bbuncrustifyplugin-xcode.

The never unopened group cantain no child item.

So far, I did not find out a method to make this group to get its child.

But maybe could be trigger by keyboard input
, alt+ right arrow. I'm trying it.

from bbuncrustifyplugin-xcode.

hi @benoitsan

Good news, I found a method to expand those selected group, finally. and those never opened group will be loaded as well.

But here, must always return YES, "Uncrustify selected files" will always be 'enable'.
Because it is no good to expand any group when user open menu > edit.

check compare

thanks!

from bbuncrustifyplugin-xcode.

Forcing to expand a group to fix the issue is not a solution IMHO, it's more a workaround. The solution would be to find the API to get the contents of the group in any case. Right now, I'm pretty busy and don't have the time to work on this but as I said, I'm interested by this feature and will invest some time in it when I can.

from bbuncrustifyplugin-xcode.

Just take your time. thanks:)

For me, I prefer like the xcode show me what files be uncrustified, rather then hide in groups.
I'm looking forward to know your work. In the meantime, I'll try to find that API you said, Get the content from group without expanding.

from bbuncrustifyplugin-xcode.

For me, I prefer like the xcode show me what files be uncrustified, rather then hide in groups.

I was thinking about the feature and now I'm not sure if taking in account selected groups is a good idea. Like you say, uncrustifying files in hidden groups is perhaps not what the user wants.

Regarding Xcode default behavior when you drag files to the Finder, dragging multiple sources files works but dragging a group doesn't work.

There are also more complexed cases when a group + nested files are selected.

If you take this case, the Xcode behavior (just taking in account selected source files) allows you to never have ambiguous decisions to make.

from bbuncrustifyplugin-xcode.

Fixed. 624c196

from bbuncrustifyplugin-xcode.