Comments (6)
@m-sureshraj if you'd like to submit a pull request please do! Thanks. Keep in mind a few things:
- the final CSS should continue to be extracted on build as it is now
- please use css-loader's built-in
?module
query param to activate modules - if I'm correct listing css-modules as a dev dependency is unnecessary? - I would like all child selectors directly under
.audio_player
to be pulled out to the top level. Deeper child classes should stay the way they are.
from cassette.
Hi @benwiley4000
I would like to work on this issue. I already used css modules for couple of my projects, so i can fix this issue.
from cassette.
@m-sureshraj This could be annoying if you've begun work on the changes already, but I made several code style updates on the master branch just now. Please pull the latest into your branch. Thanks!
from cassette.
Hi, @benwiley4000
Sure, I will pull the latest changes to my branch. Thanks 👍
from cassette.
@m-sureshraj I am now realizing that css modules may make it more difficult for users to override default styles - I'm not sure if there's a good way around this and if not we may have to abort the migration to CSS modules. What do you think?
from cassette.
I'm going to remove this from the 1.0 target for now. If you're able to find a good solution to the style override problem, feel free to still submit a PR.
from cassette.
Related Issues (20)
- Add Sass section to @cassette/player docs
- Update CONTRIBUTING doc
- ContextProvider/Consumer not working as expected HOT 22
- Google Chrome - Rewind media not working HOT 6
- Address getting started pain points
- Remove support for unsupported `displayText` property on track
- Officially migrate to @cassette packages on npm
- Example: fork Webamp and adapt to use Cassette
- Timidity midi playback plug-in (?)
- How can context updates be streamlined to cut out extraneous work?
- Handling media element errors HOT 6
- Let PlayerContextGroup handle media outside of Cassette
- Timestamp rounds up to nearest second, MediaStatusBar momentarily reads :60 HOT 2
- Set up Cypress for testing HOT 1
- Need help, not sure if I'm doing everything right. HOT 6
- Snapshot not updating PlayerContextProvider state when playlist changes. HOT 7
- Snapshot not updating PlayerContextProvider state if playlist contains different track urls HOT 5
- Setting index in PlayerContextProvider outside HOT 6
- Correct way to set pause after a track is finished but before jumping to the next HOT 1
- onSelectTrackIndex always starts playing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cassette.