Giter VIP home page Giter VIP logo

Comments (6)

benwiley4000 avatar benwiley4000 commented on June 9, 2024 1

@m-sureshraj if you'd like to submit a pull request please do! Thanks. Keep in mind a few things:

  • the final CSS should continue to be extracted on build as it is now
  • please use css-loader's built-in ?module query param to activate modules - if I'm correct listing css-modules as a dev dependency is unnecessary?
  • I would like all child selectors directly under .audio_player to be pulled out to the top level. Deeper child classes should stay the way they are.

from cassette.

m-sureshraj avatar m-sureshraj commented on June 9, 2024

Hi @benwiley4000
I would like to work on this issue. I already used css modules for couple of my projects, so i can fix this issue.

from cassette.

benwiley4000 avatar benwiley4000 commented on June 9, 2024

@m-sureshraj This could be annoying if you've begun work on the changes already, but I made several code style updates on the master branch just now. Please pull the latest into your branch. Thanks!

from cassette.

m-sureshraj avatar m-sureshraj commented on June 9, 2024

Hi, @benwiley4000

Sure, I will pull the latest changes to my branch. Thanks 👍

from cassette.

benwiley4000 avatar benwiley4000 commented on June 9, 2024

@m-sureshraj I am now realizing that css modules may make it more difficult for users to override default styles - I'm not sure if there's a good way around this and if not we may have to abort the migration to CSS modules. What do you think?

from cassette.

benwiley4000 avatar benwiley4000 commented on June 9, 2024

I'm going to remove this from the 1.0 target for now. If you're able to find a good solution to the style override problem, feel free to still submit a PR.

from cassette.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.