Comments (7)
Can you provide a basic example? I have it working in a react/redux setup without seeing the issue.
from react-overdrive.
I will try to replicate it in a fiddle
from react-overdrive.
@berzniz - If it helps any, it looks like an issue with the context of the children not being preserved. I have children of the Overdrive
component at various layers that use context
for theming purposes, and any time the overdrive component animates, non of the children components are able to get the prop they need off of context and an error is thrown saying it's undefined.
I'm not sure why this is happening, since everything I'm reading says that React.cloneElement
should preserve context properly in React 0.14 and up.
from react-overdrive.
@green-arrow is it breaking while animating? or even before that?
The animation happens on a different ReactDOM.render
tree, so I can see why the context
might not transfer there. I'll try to see if we can clone that as well.
from react-overdrive.
@berzniz to be honest I can't really tell when it happens. As soon as I reorder some items, they automatically move to the new position (no animation) and I get a console error about the context.
I think the animation not happening is probably an issue on my end, but not sure.
from react-overdrive.
Thanks @Anujan for providing the fix. It's merged but due to some git magic, the contribution was squashed and your name is not in the contributors list. Sorry.
from react-overdrive.
Thanks @arunkjn and @berzniz, that worked wonderfully.
from react-overdrive.
Related Issues (20)
- Include nextgram-overdrive demo in demos
- Broken images on demo website HOT 2
- Add Changelog HOT 1
- AnimationEnd Event HOT 2
- Make unmount requirement optional HOT 1
- Nested overdrive animations HOT 1
- Not an issue: Big thank you only! HOT 1
- Broken links HOT 1
- Custom ease ? HOT 2
- Are there similar libraries out there that you could recommend for non React projects? HOT 1
- How do I delete issue rather than Close
- Add support for react 15 and don't use unstable method HOT 1
- Homepage is down
- Support for React 16.3 and Portal ? HOT 2
- Demos in project are failing HOT 4
- Library maintence? Point to alternatives? HOT 1
- Website is down
- Transitioning components with React-router Links HOT 1
- React throws warning for unsafe componentWillReceiveProps HOT 1
- Translate animation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-overdrive.