Giter VIP home page Giter VIP logo

Comments (7)

bnjmnt4n avatar bnjmnt4n commented on May 19, 2024

Question: did you test by inputting the UA strings into the demo, or what?

from platform.js.

tomByrer avatar tomByrer commented on May 19, 2024

Real-life visitation by the real client that I really have installed.

from platform.js.

bnjmnt4n avatar bnjmnt4n commented on May 19, 2024

Ok, for PaleMoon, we don't include it in our lists of browsers, so it isn't surprising that it doesn't work. I'll try to test on Firefox Aurora when I can.

from platform.js.

jdalton avatar jdalton commented on May 19, 2024

(Outdated) FireFox Aurora
"ua": "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0"
but

"prerelease": null,`
"manufacturer": null,

That's fine we key off of indicators in the UA string or navigator object to populate the prelrelease key and manufacturer is for things like phones or ipads.

**FireFox fork PaleMoon
"ua": "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:24.0) Gecko/20140316 Firefox/24.0 PaleMoon/24.4.1"
but

"name": null,
"version": null,
"manufacturer": null,
"product": null,

I'm fine with us not detecting PaleMoon as Firefox and not adding explicit support for PaleMoon.

from platform.js.

tomByrer avatar tomByrer commented on May 19, 2024

I'm fine with us not detecting PaleMoon as Firefox and not adding explicit support for PaleMoon

Not quite sure why you support other fringe browsers & not Palemoon? Or atleast have it to show as Firefox please?

from platform.js.

jdalton avatar jdalton commented on May 19, 2024

Not quite sure why you support other fringe browsers

I've tried not to unless there was a reason, like they were on the EU browser ballot, or smth.

from platform.js.

tomByrer avatar tomByrer commented on May 19, 2024

Oh gotcha, I was hoping you'd be going for a more complete browser array like Browserscope/ua-parser.
Thanks for sharing your reasoning.

from platform.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.