Giter VIP home page Giter VIP logo

Comments (4)

josephschmitt avatar josephschmitt commented on August 30, 2024

I would expect top and left values to be relative to the element being appended to, not to the body when appendTo is set.

from horsey.

bevacqua avatar bevacqua commented on August 30, 2024

Should be fixed now.

from horsey.

msokk avatar msokk commented on August 30, 2024

Top value is correct with appendTo, but left value is still calculated from body for some reason.

from horsey.

msokk avatar msokk commented on August 30, 2024

Aha, bullseye only applies appendTo, context to top - https://github.com/bevacqua/bullseye/blob/master/bullseye.js#L76.

Would replacing the line 67 in bullseye with

el.style.left = (context ? p.x - context.getBoundingClientRect().left : p.x) + 'px'; 

make sense?

from horsey.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.