Giter VIP home page Giter VIP logo

Comments (3)

balupton avatar balupton commented on June 16, 2024 1

Interesting fix proposal. Makes sense to check if gh is authed (already done in setup-git) and use that if so, and if not, then check use the api and check the response for rate limit failure and if so do the auth flow and use gh.

an alternative would be to check if the auth token is mapped via secret or to even guide the user with how to map it via secret, but that is more involved than the above proposal

from dorothy.

balupton avatar balupton commented on June 16, 2024 1

Implementing now.

Difficulty is that gh doesn't support fetching via a release ID, which at times has been necessary, such as when locking JQ to a specific release ID.

That said, I believe that release IDs were used as filtering via tag name was fragile when jq was not present on the system. In which case, perhaps instead of just passing a release, we should pass the tag, alias, or id of a release so the fetcher can use the appropriate technique.

from dorothy.

balupton avatar balupton commented on June 16, 2024 1

I believe I've resolved this locally through a thorough rewrite of get-github-release and a partial rewrite of gihtub-download. Will do cross-platform testing tomorrow.

from dorothy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.