Comments (3)
Interesting fix proposal. Makes sense to check if gh is authed (already done in setup-git) and use that if so, and if not, then check use the api and check the response for rate limit failure and if so do the auth flow and use gh.
an alternative would be to check if the auth token is mapped via secret or to even guide the user with how to map it via secret, but that is more involved than the above proposal
from dorothy.
Implementing now.
Difficulty is that gh doesn't support fetching via a release ID, which at times has been necessary, such as when locking JQ to a specific release ID.
That said, I believe that release IDs were used as filtering via tag name was fragile when jq was not present on the system. In which case, perhaps instead of just passing a release, we should pass the tag, alias, or id of a release so the fetcher can use the appropriate technique.
from dorothy.
I believe I've resolved this locally through a thorough rewrite of get-github-release and a partial rewrite of gihtub-download. Will do cross-platform testing tomorrow.
from dorothy.
Related Issues (20)
- Improvement: Raspberry Pi OS support HOT 1
- Mention the docs folder in the readme HOT 2
- Docs: mention mount-helper
- Installation errors in supported shell in host shells in Termux and within guest shells within proot-distro aliases in Termux HOT 2
- Install error command not found on Intel Mac HOT 4
- mount-helper: fail if doing user mount on root target
- Question: Dorothy and Dotly integration? HOT 6
- Bug: `sources/ssh.nu` syntax error HOT 1
- Trouble installing dorothy on Ubuntu 22.04.3 LTS HOT 5
- Login shell restriction HOT 6
- Suggestion: simplify setup-dns
- Bug: `interactive.sh` is loaded even when `interactive.fish` exists HOT 4
- Suggestion: setup-util support for streamlined {bin,man,lib,etc} extraction HOT 4
- Bug: Dorothy sets CC to '' HOT 1
- Suggestion: Use the GitHub or GitLab CLI to setup the user repository
- Suggestion: Cross-shell aliases HOT 2
- Suggestion: ask: `--password` should use `read --silent` with a confirm password prompt HOT 2
- syntax error near unexpected token `) HOT 2
- Suggestion: choose: inline rendering by default
- Suggestion: have tty.bash trigger tty_clear on alt tty establishment
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dorothy.