`setup-mac-brew` error: `fatal: --unshallow on a complete repository does not make sense` about dorothy HOT 6 CLOSED

I am going to test and run this tonight.

from dorothy.

I posted under homebrew discussions also bc I have never seen the last error before.

from dorothy.

fatal: --unshallow on a complete repository does not make sense
fatal: --unshallow on a complete repository does not make sense
fatal: --unshallow on a complete repository does not make sense
fatal: --unshallow on a complete repository does not make sense
fatal: --unshallow on a complete repository does not make sense

So these, despite the appearance, are not fatal. Dorothy is coded in strict mode, so will actually fail if there is a proper failure. Otherwise it will keep going...

Here is the relevant code in setup-mac-brew

# Update brew
echo -e '\nUpdating homebrew...'
# trim deprecations
ok silent brew untap caskroom/cask
ok silent brew untap caskroom/fonts
# fix: Error: homebrew-cask is a shallow clone
# uses `ok` as if already done, wil fail with: fatal: --unshallow on a complete repository does not make sense
brewrepodirs="$(echo-subpaths "$(dirname "$(brew --repo homebrew/core)")")"
for directory in $brewrepodirs; do
	ok git -C "$directory" fetch --unshallow
done

The issue is one of changing conventions over time with brew, and at one point they recommended shallow clones to prevent the intense load on github, but then that prevented upgrading, so hence the need for --unshallow. All it's saying is that the repo has already been converted to unshallow.

That said, this of course is bizarre to someone not familiar with what's happening, so it is indeed a bug - as there should be no need to be aware of this. The reason it isn't just a silent on it, is because we want to still capture other error messages.

For the other issues you've had:

Error: Problems with multiple casks:
criptext: It seems there is already an App at '/usr/local/Caskroom/criptext/latest/Criptext.app'.
drawio: It seems there is already an App at '/usr/local/Caskroom/drawio/13.0.3/draw.io.app'.
keepassxc: It seems there is already an App at '/usr/local/Caskroom/keepassxc/2.5.4/KeePassXC.app'.
reaper: It seems the App source '/Users/hjalmarjakobsson/reaper/app/RPPTEST/REAPER.app' is not there.
teensy: It seems there is already an App at '/usr/local/Caskroom/teensy/latest/teensy.app'.

This seems that at some point brew was not cleaned up properly, or simply not cleaned after a prior install. Run setup-mac-clean and then try again setup-mac-brew. If it is the same issue, then run brew doctor and follow the instructions.

We need to do some thinking on a better way to work around this. Would grep'ing out that expected error message work, or should we just inform the user to ignore it.

from dorothy.

I've nearly finished rewriting the command to address the issues here.

from dorothy.

Nice!

from dorothy.

Fixed in ae0c5ee

You will still need to run brew doctor to resolve the issue with:

Error: Problems with multiple casks:
criptext: It seems there is already an App at '/usr/local/Caskroom/criptext/latest/Criptext.app'.
drawio: It seems there is already an App at '/usr/local/Caskroom/drawio/13.0.3/draw.io.app'.
keepassxc: It seems there is already an App at '/usr/local/Caskroom/keepassxc/2.5.4/KeePassXC.app'.
reaper: It seems the App source '/Users/hjalmarjakobsson/reaper/app/RPPTEST/REAPER.app' is not there.
teensy: It seems there is already an App at '/usr/local/Caskroom/teensy/latest/teensy.app'.

from dorothy.