iesafe option does not work about svg-url-loader HOT 7 CLOSED

@alex-shamshurin: just a little ping, if you can describe in more detail what the problem is, I'd be happy to take a look at it.

from svg-url-loader.

If you look at the source code, it has an additional requirement: your content needs to have a style tag.

from svg-url-loader.

No matter, IE11 does not work with SVG class too. It must not be inlined to support IE11. This option should fix it without other conditions.

from svg-url-loader.

@kgram, as an author of iesafe option, do you have any thoughts on this?

from svg-url-loader.

@alex-shamshurin: I don't understand what aspect of classes you would expect to work without a style-tag. Is the problem internal references to masks or something?

I wasn't aware of any broken features besides style-tags, so I made a check to avoid unnecessary bailouts. In my defense, I did document it under the option description ("[..]if the file contains a style-element and the encoded size is above 4kB[..]"). Can you possibly post an example of an SVG that doesn't work (possibly with path-data removed if it's sensitive, hopefully the problem will still be visible)? It's possible the style-tag check should just be removed to be completely safe.

from svg-url-loader.

leyserPlusLogo.zip

hi, @kgram The svg has style tag, but in ie11, it's has been convert to inline data-url svg and only has black color. I expect it fallback to fileloader.

The loader option:

{
        test: /\.(svg)$/,
        use: [{
          loader: 'svg-url-loader',
          options: {
            limit: 10000,
            iesafe: true,
            encoding: 'base64'
          }
        }]
      },

Regards.

from svg-url-loader.

I had expected some sort of weird IE behaviour when using base64, but it turned out to be plain stupidity from myself. When I wrote the feature I forgot that . in regex does't match line breaks. All my generated examples are without extra whitespace and everywhere I use the loader myself I have it placed after an optimiser that strips the extra whitespace, so I've never noticed it.

I'm sorry for any trouble my oversight has caused. The good news is that until a new release is ready the problem should be fixable by placing an optimiser-loader such as svgo-loader before the svg-url-loader.

from svg-url-loader.