Possible memory leak about http.swift HOT 5 CLOSED

Hey! Thank you for your care!

DispatchQueues does not cause retain cycles, they dispose passed closure after calling them, meaning they do not retain reference to the closure passed.

To be honest, the library needs a total rewrite.

from http.swift.

Hi — thanks for your explanation. So if I can't blame my leak on your code I will have to fix mine lol

from http.swift.

Oh man. Over time my code potentially opens and closes quite a few Servers, one after the other, and they were retaining just because I forgot to call .stop() on them when I was finished with each instance 🤪 Spent such a long time searching for the cause of this leak!

Interesting, I suppose, that the Server instances appear to self-retain until stopped, but it's kinda obvious when I think about it. Anyway, definitely my fault in the end!

from http.swift.

Lol. Yeah they will retain until stopped because of missing [weak self] in the queue closure that you wanted to add. I think it would be better to do it. Would you like to send a quick PR for that?

from http.swift.

Sure, doing now :)

from http.swift.