Giter VIP home page Giter VIP logo

Comments (12)

Bluejade avatar Bluejade commented on September 4, 2024

This error appeared in a recent update of authlogic_openid. With version 1.0.4, all of my tests pass. With the current version, several things break, including the problem you mention here.

from authlogic_openid.

taddgiles avatar taddgiles commented on September 4, 2024

so your tests pass with authlogic_openid 1.0.4? And which version of authlogic are you using?

from authlogic_openid.

Bluejade avatar Bluejade commented on September 4, 2024

I was using 2.0.14, but have now upgraded to 2.1.1. Both pass all my tests. When I upgrade authlogic_openid to the current version, I get errors and assertion failures. The errors are the same one you report above: missing user_sessions/create.html.erb template.

from authlogic_openid.

dbarison avatar dbarison commented on September 4, 2024

same problem here, with lastest version.
authlogic 2.1.1 + authlogic-oid 1.0.4 all ok.

from authlogic_openid.

taddgiles avatar taddgiles commented on September 4, 2024

yup, confirmed, authlogic 2.0.14 and authlogic-oid 1.0.4 pass for me too.

from authlogic_openid.

sporkd avatar sporkd commented on September 4, 2024

I posted something to the google group a while back about a commit that was made almost a month ago... You guys might want to check if it's the same issue I was having.

http://groups.google.com/group/authlogic/browse_thread/thread/fdc8dad50e8cf267/203f774bad6faa46?lnk=gst&q=block#203f774bad6faa46

from authlogic_openid.

dbarison avatar dbarison commented on September 4, 2024

yes this solution fix this problem, thnx sporkd.
now remains some problems with auto_register enabled.

from authlogic_openid.

tfe avatar tfe commented on September 4, 2024

Is there any chance of this being fixed and released in the official gem? I cannot modify code as in sporkd's link since I don't have control over gems in my deployment environment (Heroku), but can only reference ones that are in the gem repositories.

from authlogic_openid.

sporkd avatar sporkd commented on September 4, 2024

Does heroku only let you use the official gem? i.e. can you not build your own? http://gems.github.com

If this is not possible, I would post to the thread up on the google group, as I'm not sure if ben checks these issues very often.

from authlogic_openid.

bmishkin avatar bmishkin commented on September 4, 2024

See line 71 of lib/authlogic-oid/session.rb . When using authlogic-oid, it clears out the block:

  def save(&block)
    block = nil if !openid_identifier.blank?
    super(&block)
  end

leaving us with no render at all, so the default create template gets loaded.

My fix is to move the render on fail outside the block in the controller, and condition it on the record saving:

render :action => "new" if @user_session.new_record? # workaround for render inside authlogic-oid

from authlogic_openid.

davidsf avatar davidsf commented on September 4, 2024

bmishkin: Can you post your controller, please ? thx.

from authlogic_openid.

omarkarim avatar omarkarim commented on September 4, 2024

The following might be worth a try:

def create
@user_session = UserSession.new(params[:user_session])
@user_session.save do |result|
if result
flash[:notice] = "Successfully logged in."
redirect_to root_url
end
end
if !performed? # no render or redirect yet
render :action => 'new'
end
end

from authlogic_openid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.