Giter VIP home page Giter VIP logo

Comments (9)

aj3sh avatar aj3sh commented on July 17, 2024 1

Sure @binodnepali, I will take a deep dive into the commit-and-tag-version documentation. I don't see a direct implementation for using it with GitHub Actions. Even they are using release-please for their releases 😆.

In the meantime, if anyone is interested in this issue, please feel free to proceed.

from react-nepali-datetime-picker.

aj3sh avatar aj3sh commented on July 17, 2024 1

@binodnepali, I would like to confirm the scope of this issue:

  1. Create a git tag and GitHub release
  2. Update the changelog file
  3. Publish the package to npm
  4. Create a PR with the release changes (package.json, CHANGELOG.md, etc.)

If I missed anything or added any extras, please let me know.

And on what event do we want to trigger the release workflow?

from react-nepali-datetime-picker.

binodnepali avatar binodnepali commented on July 17, 2024 1

@aj3sh I saw you guys using release-please in node-datetime package. if you would like to proceed with release-please. I am fine with it as well :)

from react-nepali-datetime-picker.

aj3sh avatar aj3sh commented on July 17, 2024 1

@binodnepali, Let's try commit-and-tag-version first.

from react-nepali-datetime-picker.

aj3sh avatar aj3sh commented on July 17, 2024 1

I am able to create releases from commit-and-tag-version through GitHub Actions. I have a question about which event should trigger the release.

Manual Dispatch

  • Users manually run the release workflow from the GitHub UI.
  • A release and tag are created.
  • A release PR is generated.

Git Tag Push

  • A user pushes a version tag (Version should be specified).
  • The tag is deleted, and a new tag is created using commit-and-tag-version.
  • A release is created.
  • A release PR is generated.

Main Branch Push

  • This method cannot be used due to recursive action triggers on release PR merge.

My recommendation is to use Manual Dispatch. Whenever we feel a release is necessary we trigger the release action manually.

cc: @binodnepali

from react-nepali-datetime-picker.

aj3sh avatar aj3sh commented on July 17, 2024

I want to contribute to this. Can we use release-please?

from react-nepali-datetime-picker.

binodnepali avatar binodnepali commented on July 17, 2024

Hey @aj3sh Thanks for your interest to contribute. I would go for commit-and-tag-version which forked version of standard version. Let me your thoughts on it :)

from react-nepali-datetime-picker.

binodnepali avatar binodnepali commented on July 17, 2024

I am able to create releases from commit-and-tag-version through GitHub Actions. I have a question about which event should trigger the release.

Manual Dispatch

  • Users manually run the release workflow from the GitHub UI.
  • A release and tag are created.
  • A release PR is generated.

Git Tag Push

  • A user pushes a version tag (Version should be specified).
  • The tag is deleted, and a new tag is created using commit-and-tag-version.
  • A release is created.
  • A release PR is generated.

Main Branch Push

  • This method cannot be used due to recursive action triggers on release PR merge.

My recommendation is to use Manual Dispatch. Whenever we feel a release is necessary we trigger the release action manually.

cc: @binodnepali

Thanks for trying out and providing summary. If you have time, can you open PR with setup? I have look into it.

from react-nepali-datetime-picker.

aj3sh avatar aj3sh commented on July 17, 2024

@binodnepali, sorry for the late response. I've been a bit busy lately.

I have created a draft PR. Please review it.

from react-nepali-datetime-picker.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.