Comments (9)
Sure @binodnepali, I will take a deep dive into the commit-and-tag-version documentation. I don't see a direct implementation for using it with GitHub Actions. Even they are using release-please for their releases 😆.
In the meantime, if anyone is interested in this issue, please feel free to proceed.
from react-nepali-datetime-picker.
@binodnepali, I would like to confirm the scope of this issue:
- Create a git tag and GitHub release
- Update the changelog file
- Publish the package to npm
- Create a PR with the release changes (package.json, CHANGELOG.md, etc.)
If I missed anything or added any extras, please let me know.
And on what event do we want to trigger the release workflow?
from react-nepali-datetime-picker.
@aj3sh I saw you guys using release-please in node-datetime package. if you would like to proceed with release-please. I am fine with it as well :)
from react-nepali-datetime-picker.
@binodnepali, Let's try commit-and-tag-version first.
from react-nepali-datetime-picker.
I am able to create releases from commit-and-tag-version through GitHub Actions. I have a question about which event should trigger the release.
Manual Dispatch
- Users manually run the release workflow from the GitHub UI.
- A release and tag are created.
- A release PR is generated.
Git Tag Push
- A user pushes a version tag (Version should be specified).
- The tag is deleted, and a new tag is created using commit-and-tag-version.
- A release is created.
- A release PR is generated.
Main Branch Push
- This method cannot be used due to recursive action triggers on release PR merge.
My recommendation is to use Manual Dispatch. Whenever we feel a release is necessary we trigger the release action manually.
cc: @binodnepali
from react-nepali-datetime-picker.
I want to contribute to this. Can we use release-please
?
from react-nepali-datetime-picker.
Hey @aj3sh Thanks for your interest to contribute. I would go for commit-and-tag-version which forked version of standard version. Let me your thoughts on it :)
from react-nepali-datetime-picker.
I am able to create releases from commit-and-tag-version through GitHub Actions. I have a question about which event should trigger the release.
Manual Dispatch
- Users manually run the release workflow from the GitHub UI.
- A release and tag are created.
- A release PR is generated.
Git Tag Push
- A user pushes a version tag (Version should be specified).
- The tag is deleted, and a new tag is created using commit-and-tag-version.
- A release is created.
- A release PR is generated.
Main Branch Push
- This method cannot be used due to recursive action triggers on release PR merge.
My recommendation is to use Manual Dispatch. Whenever we feel a release is necessary we trigger the release action manually.
cc: @binodnepali
Thanks for trying out and providing summary. If you have time, can you open PR with setup? I have look into it.
from react-nepali-datetime-picker.
@binodnepali, sorry for the late response. I've been a bit busy lately.
I have created a draft PR. Please review it.
from react-nepali-datetime-picker.
Related Issues (11)
- docs: create doc site HOT 7
- Compatibility HOT 1
- chore: add demo site
- refactor: components to use daisyUI component library
- fix: AM shown when time is 12 o'clock afternoon
- refactor: use AM and PM for Nepali language as well HOT 1
- fix: inconsistent months date show in the calendar view for 2081
- refactor: way to constructor months data constant
- docs: improve docs site HOT 3
- BUG: Date with Day does not match on some years HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-nepali-datetime-picker.