🐛 Issue with 'ignore' functionality in version 1.5 about biome HOT 10 CLOSED

I just did, that doesn't fix it. Removing the ./**/* for . was the real fix for me. Then it respects my ignore.

from biome.

For example, the following is an example of the behavior when the 'module' directory is set in the 'ignore' configuration but is not being ignored:

❯ bun run biome check .
Checked 800 file(s) in 33ms

❯ bun run biome check . // Removed only the 'module' directory without changing the biome configuration
Checked 276 file(s) in 23ms

In this scenario, even though the 'module' directory is specified in the 'ignore' list, it is not excluded from processing, as demonstrated by the number of files checked in both cases.

from biome.

Hi @riya-amemiya

You gave us zero information to work with, so it's literally impossible for us to help you to triage the issue.

Please, share with us a minimal reproduction. You can use our codesandbox template too, you can find the link in the issue form

from biome.

@ematipico

I apologize for any inconvenience, and thank you for your polite response. I will share the minimum configuration.

https://github.com/riya-amemiya/biome-sandbox

from biome.

Hi @riya-amemiya.

I checked your reproduction.
Assuming that you mean src instead of module in your reproduction, Biome linter/formatter seems to correctly ignore fiels under src/ and .codesandbox/.
However, the reported number of processed files is indeed incorrect.

The bug is not present if the files/directories are ignored globally using files.ingnore.

from biome.

I had a similar issue upgrading to 1.5.2 (from 1.4.1). I have this section in my biome.js:

"files": {
    "ignoreUnknown": true,
    "ignore": ["node_modules/*", "./node_modules/*"]
  }

And biome still included node_modules and gave a bunch of symlink errors.

from biome.

I had a similar issue upgrading to 1.5.2 (from 1.4.1). I have this section in my biome.js:

"files": {
    "ignoreUnknown": true,
    "ignore": ["node_modules/*", "./node_modules/*"]
  }

And biome still included node_modules and gave a bunch of symlink errors.

I actually found a fix for my issue:

For biome 1.4.1 I had this pnpm script in my package.json:

biome check --error-on-warnings --formatter-enabled=true --linter-enabled=true --organize-imports-enabled=true ./**/*

And for 1.5.2 I had to modify it to this:

biome check --error-on-warnings --formatter-enabled=true --linter-enabled=true --organize-imports-enabled=true .

So the problem was the wildcard at the end.

from biome.

Have you tried node_modules/** instead?

from biome.

I just did, that doesn't fix it. Removing the ./**/* for . was the real fix for me. Then it respects my ignore.

./**/* is expanded by your shell to all files. Thus, this passed to Biome all files, including the one in node_modules forcing Biome to take a look at these paths.

from biome.

CLoding since it is now resolved :)

from biome.