Giter VIP home page Giter VIP logo

Comments (4)

fujiyamaorange avatar fujiyamaorange commented on June 12, 2024 1

@Conaclos
The eslint link looks same as #2610 👀

from biome.

ematipico avatar ematipico commented on June 12, 2024 1
  1. Yeah you're right, the third case is weird. In that case, we should suggest a different role (covered by another rule I think). We should ignore it.
  2. Usually we start without options unless they are needed for the first round of implementation.

from biome.

DerTimonius avatar DerTimonius commented on June 12, 2024

I'd like to work on this one 🙂

from biome.

DerTimonius avatar DerTimonius commented on June 12, 2024

Currently working on this, I'm already making good progress!

There are two questions that came up:

  1. Should the third case of the original rule be included here? To me, it feels a bit disconnected

Case: This element is not a button, link, menuitem, etc. It is catching bubbled events from elements that it contains
If your element is catching bubbled click or key events from descendant elements, then the proper role for this element is presentation.

<div
  onClick={onClickHandler}
  role="presentation">
  <button>Save</button>
</div> 

Marking an element with the role presentation indicates to assistive technology that this element should be ignored; it exists to support the web application and is not meant for humans to interact with directly.

  1. Should the rule have options to make some elements not only focusable, but also tabbable as suggested in the original rule?

from biome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.