Comments (4)
@Conaclos
The eslint link looks same as #2610 👀
from biome.
- Yeah you're right, the third case is weird. In that case, we should suggest a different role (covered by another rule I think). We should ignore it.
- Usually we start without options unless they are needed for the first round of implementation.
from biome.
I'd like to work on this one 🙂
from biome.
Currently working on this, I'm already making good progress!
There are two questions that came up:
- Should the third case of the original rule be included here? To me, it feels a bit disconnected
Case: This element is not a button, link, menuitem, etc. It is catching bubbled events from elements that it contains
If your element is catching bubbled click or key events from descendant elements, then the proper role for this element is presentation.
<div
onClick={onClickHandler}
role="presentation">
<button>Save</button>
</div>
Marking an element with the role presentation indicates to assistive technology that this element should be ignored; it exists to support the web application and is not meant for humans to interact with directly.
- Should the rule have options to make some elements not only focusable, but also tabbable as suggested in the original rule?
from biome.
Related Issues (20)
- 📎 Implement `unicorn/prefer-array-index-of`
- 🐛 invalid char boundary in diagnostics
- 📎 Forbid `undefined` as type name
- 🐛 <WasmError> HOT 4
- 💅 [nursery/useDateNow] Incorrect applying to Date.now() to all Date.prototype.getTime HOT 2
- 💅 `lint/correctness/noStringCaseMismatch` false positives
- 💅 `lint/correctness/noUnusedVariables` false positives
- 📝 biome ci always produce errors in GHA but not locally HOT 1
- 🐛 Github Reporter not generating annotations correctly HOT 1
- 💅 `lint/complexity/noUselessFragments` crashes when applying fix in some cases
- 📎 Change `bit_flags` for `enumflags2`
- 💅 There is a false positive in the `useLiteralKeys` rule HOT 1
- 🐛 `biome lsp-proxy` hangs with certain input
- 🐛 CSS parsing and Unicode point ranges
- 🐛 Override behavior with multiple matches HOT 1
- 📎 Import sorter revamping - custom order
- ☂️ Analyzer assists
- 🐛 `npx @biomejs/biome migrate` command crashes HOT 5
- 📝 CSS formatter converts custom identifiers to lowercase HOT 1
- ☂️ Type-aware linter
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from biome.