Comments (15)
Should I create an array to store all the deprecated arguments, in order to leave it generic for future uses?
It's possible that in the future we don't deprecate an option for another, that's why a generic message is more future proof
from biome.
Oh, I guess the previous windows users didn't use this command 😔 not sure how to fix that, I don't use windows
You can still write a test, they are very reliable, and we have many of them
from biome.
What would be the best or correct way to add this option? I tried putting it in the formatter configuration in the rome_service crate, but that breaks tests that apparently don't use the indent-size option through the CLI.
That's the correct place. I'm not sure what you mean when tests break, maybe the best option is opening a draft PR so we can look a it, when code at hand.
from biome.
I understand now. Still, it would be great to see some code, so I can better understand the implementation, and give suggestions. It's fine there aren't any tests, that's what draft PRs are also good for: get feedback
from biome.
width
is more in line with the meaning of the word given its context, because it's applied on a line. And it's also in line with line_width
.
from biome.
I will try to do this
from biome.
Should I use/create a diagnostic struct for this? Where should I check the provided option?
I'm thinking of doing based on #107 if you have any tips better.
from biome.
Should I use/create a diagnostic struct for this? Where should I check the provided option?
Yes, you'll have to create a new diagnostic.
biome/crates/rome_cli/src/diagnostics.rs
Lines 23 to 60 in ef3af45
You could create a generic DeprecatedArgument
inside this enum, that accepts a generic message. Or a loose diagnostic like in #107. This the latter is a better solution
I'm thinking of doing based on #107 if you have any tips better.
Yes that's right!
from biome.
Should I create an array to store all the deprecated arguments, in order to leave it generic for future uses?
from biome.
When I run the CLI command (cargo run --bin biome -- --help), it gives the following error: thread 'main' has overflowed its stack
.
I'm using Windows.
from biome.
To run the CLI, do
cargo biome-cli-dev --help
from biome.
I tested this command now, and it also gave the same error.
from biome.
I'm sorry I didn't ask for this information sooner
What would be the best or correct way to add this option? I tried putting it in the formatter configuration in the rome_service crate, but that breaks tests that apparently don't use the indent-size option through the CLI.
I checked the deprecated option in the or_diagnostic
function equal to #107.
Is there anything I forgot to do or did wrong?
from biome.
Explaining better: the way I used to check the indent-size option (very similar to #107) apparently takes the settings from the configuration file, which causes the diagnostic to be run even without pass the deprecated CLI option.
If you still don't understand, I committed an early version (without tests) of what I tried to do, and I can make a draft pull request.
from biome.
I first thought this was a good idea. However, I am starting to wonder if it is still. Prettier and .editorConfig
use indent_size
.
from biome.
Related Issues (20)
- 📝 Comment near a computed key in a union type gets duplicated
- ☂️ Translate the website into Bahasa Indonesia/Indonesian (id)
- ☂️ Translate the website into Turkish (tr) HOT 1
- ☂️ Translate the website into Arabic (ar)
- 📎 Implement `lint/useNumberNamespace` - `eslint-unicorn/prefer-number-properties` HOT 3
- 📎 Implement `lint/noThenable` - `eslint-unicorn/no-thenable` HOT 1
- 📚 Documentation issue labelling test
- 📎 Allow empty type parameter list for interfaces and type aliases HOT 2
- 🐛 Some syntax rules are not enabled
- 🐛 Biome doesn't throw errors for files that can't handle
- 📎 Adding support for Astro
- 🐛 <TITLE> error parsing empty function
- Add support for `biome.jsonc`
- 📎 Add code fix for `lint/useNodeImportProtocol` HOT 1
- CSS Parser: parse font palette values at rule
- 📎 Reduce the memory of our internal configuration
- 📚 How to ignore a path HOT 1
- CSS Parser: parse keyframes
- 💅 `noUnusedImports` does not work with using TS `declare const` HOT 5
- 📎 Tailwind class sorting lint rule HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from biome.