Giter VIP home page Giter VIP logo

Comments (4)

thejmazz avatar thejmazz commented on August 19, 2024

@mafintosh @maxogden your thoughts? making Task a duplex alway that wraps an inner stream, and then having its first and last chunks be specific objects, be too much of a complication? It would mess up a.pipe(b).pipe(c) since the custom objects would be stuck in, not sure atm how to get around that, somehow only pipe through the inner stream but also be able to check for task.begin and task.done events on the outer stream returned by Task

Also, forcing it to be a stream would help with async - #4.
Streams > promises.

Or just pass in params lol..

from bionode-watermill.

thejmazz avatar thejmazz commented on August 19, 2024
  • try using object instance on property

from bionode-watermill.

thejmazz avatar thejmazz commented on August 19, 2024

did not actually do this, was resolving from fs

from bionode-watermill.

thejmazz avatar thejmazz commented on August 19, 2024

@mafintosh I attached a function output to the stream object inside task, then when join sees a .on('end' /* or finish */'), it will call this.output() to get the actual values.

I tried attaching a bare object first (see closing commit before reopen), from inside task, after end/finish, but then the end/finish handler from join doesnt get it

not sure if theres another way to do it when you can just attach an object rather than a closured function

from bionode-watermill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.