Comments (2)
BioPhoton
commented on June 8, 2024
Hi @MohsenAra you are right. We have to inject it. At the time it was a first step to a configurable module. Because of heavy workload on other projects i did not finished it.
The goal would be to create a static forRoot method in your module class.
There under providers we have to place the StarRatingConfig service. We then are able to inject it into the constructor in star-rating.ts.
A second step then would be to accept a param in the forRoot method which is the Obj or service with the custom settings. In the method we could merge these settings into a new service and provide it under StarRatingConfig. You could use the interface of StaRatingConfig to type your custom settings.
When i have a bit more time i will finish configurable module features.
But i also would merge a earlier PR of your approach ;-)
Best Michael
from angular-star-rating.
BioPhoton
commented on June 8, 2024
Fixed in latest version
from angular-star-rating.
Related Issues (20)
- Cannot read property 'toString' of null HOT 1
- How to remove the default tooltip? HOT 2
- How to disable tabindex? A rect focused border is annoying HOT 4
- Hover Color Stops Working for Green Stars HOT 1
- Upgrade to Angular 7.3 HOT 11
- Hover effect does not work when hoverEnabled, showHalfStar, readOnly property is set to true. HOT 1
- Support for floating numbers in rating.
- Unit Test in Reactive Form
- Custom size beyond small, medium, and large options HOT 2
- Support for Angular v9 HOT 2
- compound selectors may no longer be extended. SCSS needs update!!!! HOT 2
- Fix problem with eslint HOT 1
- Setup automated release
- Angular Stuck on Compiling HOT 3
- console.log made it into production HOT 3
- Cannot find the star-rating.scss at the path ~angular-star-rating/assets/scss/star-rating HOT 2
- Unable to use Library with Angular v.11 HOT 3
- No value accessor for form control with name HOT 1
- Required - Readonly mode in star rating component HOT 2
- Half star doesn't work after upgrading to Angular v16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-star-rating.