Comments (6)
@gmarupilla Could you work on this as well? We need to get every test passing atleast for the unit tests. As we add more components it will get harder to manage so we should get this done before any further work
from biosimulations.
Yeah! Sure.
from biosimulations.
I looked into it. The problem with writing tests right now is that the requirement is not very concrete as of now. If i write tests right now, they'll have to be changed again once we start developing according to OAS file. What do you think?
from biosimulations.
We should definitely have the tests set up even though the spec is not finalized.
Firstly for unit tests, the majority of the test cases will not be dependent on the structure of objects but tests more basic features like ensuring that a list is properly populated or that the links and routing work. The ones that do rely on the objects Should fail if the spec changes so that we know that the front end needs updating.
Secondly, the e2e integration tests should not be dependent on the spec at all, but instead ensure that the site is working, regardless of what the api is sending out. Is a spec change breaks the e2e tests then that is a sign that the site needs to be adapted to the new spec, not that the tests must be changed.
from biosimulations.
@gmarupilla
All the tests have been fixed except for 2, the vega-viewer component and the file-edit component.
Both are giving an error about a parameter being null. For both components, the parameter is set using an HTTP Request.
We need to follow the below directions to mock the HTTPS request and give back a test parameter for the components to render.
from biosimulations.
fixed partially by #35
New issues opened for individual tests failing
from biosimulations.
Related Issues (20)
- 🐛: create project fails when writing to S3 HOT 1
- deploy development software version to production site HOT 1
- substract an additional 52px when the privacy notice is visible
- substract an additional 52px when the privacy notice is visible
- 🐛: 'run' page doesn't allow steady state substitutions HOT 1
- Log page left scrollbar problems HOT 2
- Should scroll back up when hit 'submit' HOT 1
- Too much whitespace in log tab HOT 2
- Run tabs all different widths HOT 2
- 'view chart' not working HOT 1
- Log files misaligned to not show everything HOT 3
- 'simulation specification' tab probably lying about having no image to display HOT 1
- Clicking on tabs should give new URL HOT 1
- 'run a new simulation' page needs to be redesigned HOT 2
- Auto-expand all 'details' information for projects HOT 2
- move 're-run' outside of the box HOT 1
- Graphs cut off legend HOT 1
- https://github.com/biosimulations/biosimulations/issues/new/choose doesn't have basic option
- Links to the log tab go instead to the viz tab
- write attributes to group without dataset array
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from biosimulations.