Comments (3)
Ok, I'll require users to include it, thanks. There is pretty much no backwards compatibility required at this point. Maybe we'll decide later that finch should assume some default units, but I don't think that should be the case.
from finch.
@huard , I think this is the problem I get in the test test_heat_wave_index
in the development branch. I think this is related to the change in xclim about the units for the thresholds. I saw a Todo saying remove backwards compatibility of int/float thresholds after v1.0 release
and that's pretty much what I'm trying to do, except that pywps sends a stringified integer.
My question is mainly: should the user running the process on pywps include the units for the threshold field? Should finch check that the literalinput ends with degC
and if not append it?
Here is the error I get when I send a string to the process: https://travis-ci.org/bird-house/finch/builds/526573759?utm_source=github_status&utm_medium=notification
from finch.
Yes. We reached the conclusion that having data in K and thresholds defaults in C would cause confusion unless units were explicit. If you want to maintain backward compatibility, you may assume temperature units for thresholds are in Celsius and append degC. With xclim 1.0, we'll require units to be explicitly provided by users.
from finch.
Related Issues (20)
- Adapt dataset extraction for CanDCS-U6
- Finch 0.9.1 docker image fails to run HOT 3
- subset_bbox_dataset fails with output_format=csv HOT 2
- dap_subset.ipynb broken with upcoming Jupyter env on PAVICS HOT 1
- Validate changes in available processes HOT 4
- Non-resampling xclim indicators wrapped into ensemble processes HOT 1
- Use flask for the development server HOT 1
- csv_precision not working as expected HOT 4
- Allow ensemble processes to return the dataset with individual realizations HOT 4
- Implement Humidex days over thresh calculation
- Add CCCS humidex ensemble to dataset options
- candcs-u6 "26 model" model list not finding 26
- What kind of bird is Finch? HOT 3
- Humidex optional arguments have minOccurs set to 1 HOT 3
- Duplicate `AllowedValues` entries in `ensemble_grid_point_wetdays` process
- Reorder csv output columns
- Distinct models should have distinct columns in CSV output HOT 1
- Incorrect output in `finch-usage` notebook HOT 3
- Migrate `master` branch to `main` HOT 1
- `unidecode` is under GPLv2 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from finch.