Comments (7)
I think this sounds like a good idea. What are the potential drawbacks, apart from losing a little bit in unfavorable rounding?
from proposals.
If you want to round without loss, you need enough decimal places on the crypto side. That would mean that there would be crooked amounts. If this is not desired or generates other disadvantages, then you can regulate this via the exchange rate or simply round up or down the decimal places without touching the crypto side. The missing 1-99 cents for one side are the costs for the privacy, on the average that is again free, since everyone buys and sells sometimes, wins and loses sometimes. In percentage terms, it is also not as much for the amounts usually traded.
from proposals.
To be clear, @marco4444, is this something that you are proposing to implement yourself if others approve it here?
The idea seems like a good one, and would require more thought, but without someone to implement it, discussing and approving a proposal doesn't make much difference.
We just published a document about the proposal process here that you might want to take a look at. Thanks in any case for submitting this. http://docs.bisq.network/proposals.html
from proposals.
@marco4444 @cbeams I think this is something that would be better as an issue under the correct repo, with discussion and implementation details there. If it turns out to be controversial it will be noticed, otherwise just implemented as a generally accepted improvement.
from proposals.
Thanks. I think I posted this already on all bisq forums, all like the proposal but recommend to post it in another area of the bisq space. I think this is the 3rd or 4th time I wrote this down.
I'm not a java programmer and not experienced with github and the bisq code so from technical point of view I cannot manage this change on my own. I can only give the idea and the math behind, consulting how the result should look like. It's now posted on several places (always following recommendations where it should be posted) and if someone pics it up to implement I can give feedback whenever wanted. If not I can recommend everybody to use it manually (by making sure the offer has a fixed Euro amount with 0 Cents), which already works now,
from proposals.
@marco4444 Don't be disheartened, I don't mean to just push the issue around. There is currently quite a lot of reorganization of how we do things around Bisq. There are many new contributors and hopefully more to come and finding a good work flow will help with that. My comment was more to figure out how we handle new issues and not really on topic, sorry for that.
Regarding the implementation. Someone needs to take ownership for it to happen, and since it affects the trading protocol some caution should be taken, even though it seems like a fairly easy thing to do. In my opinion it's best to create an issue in bisq-core and start a discussion on implementation there. I created an issue bisq-network/bisq-core#101
from proposals.
Closing as moved to bisq-network/bisq-core#101. Thanks @sqrrm for taking care of that.
from proposals.
Related Issues (20)
- Bisq2 oracle node operator HOT 3
- Bisq2 seed node operator HOT 3
- Bisq2 Security Manager HOT 3
- Application to become a bonded explorer operator HOT 4
- Application to become a bonded price node operator HOT 4
- Application to become a mediator for Bisq 2 HOT 4
- Application to become a moderator for Bisq 2 HOT 7
- Bisq2 Release Manager HOT 3
- Application to become a mediator for Bisq 2 HOT 3
- Bisq2 Release Manager HOT 5
- Application to become a moderator for Bisq 2 HOT 5
- Bisq2 seed node operator HOT 5
- Bisq2 oracle node operator HOT 4
- Bisq2 Security Manager HOT 3
- BSQ trading fee update on Cycle 53 HOT 4
- Plan for Projects Maintainer role: First Stage HOT 4
- BSQ trading fee update on Cycle 55 HOT 13
- Proposal for @solomon1923 to assume Growth Lead role HOT 1
- Application to become a bonded pricenode operator HOT 3
- Show a Warning for potentially misconfigured network settings
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proposals.