Giter VIP home page Giter VIP logo

Comments (11)

ripcurlx avatar ripcurlx commented on June 23, 2024 2

Re 2: I'm also for extending the vote reveal phase to the same length of the vote phase, as it might be frustrating if someone voted, but didn't get her vote count because of the short reveal time. Maybe we should think about adding the phases to the event calendar so people could get alerts when they need to start up their client? Doing it via the mobile app might also be a way to do it, but then we need to find a good way to synchronize it.

I agree with everything else 👍

from proposals.

ManfredKarrer avatar ManfredKarrer commented on June 23, 2024 2

So lets change from 4 days to 3 days for blind vote and from 2 days to 3 days for vote reveal.

from proposals.

justpaulgmx avatar justpaulgmx commented on June 23, 2024 1

Well thought out as always, +1 here.

from proposals.

ManfredKarrer avatar ManfredKarrer commented on June 23, 2024 1

I would say lets close that if noboday has further concerns.

from proposals.

devinbileck avatar devinbileck commented on June 23, 2024

A few comments.

  1. Is it necessary to have an extended PHASE_BREAK1? Would any discussions/reviews at this point be too late since if a reviewer asks the requester to adjust their requested amount they would be unable to since we don't have the ability to edit proposals and cannot submit a new one during this phase. Perhaps asking the requester to provide more context/background to their request would be acceptable during this phase, but could/should that instead be done during PHASE_BLIND_VOTE? As I suspect most users may just review proposals while casting their votes anyways.

  2. Should PHASE_VOTE_REVEAL be increased? My concern is that 2 days might not be enough time (e.g. no computer/internet access while travelling or away during a long weekend). At least 3 or 4 days might be better. And perhaps starting with a longer phase when the DAO launches might be better than the alternative (users missing the phase; invalidating their vote) and can always be decreased via DAO voting at a later point in time if it is determined that a majority of votes are revealed within 2 days.

  3. I guess we also need to decide max increase/decrease of these parameters via DAO voting for these phases as well? Since the max increase/decrease itself cannot be changed via DAO voting, we need to get it right before the DAO launch (unless we want to be able to vote on those as well?). All phases have a max increase/decrease of 3, except for PHASE_BREAK2 which has a max increase of 23 (not sure if that is just a typo?).

from proposals.

ManfredKarrer avatar ManfredKarrer commented on June 23, 2024

Re 1:
We had some discussions around that in the past so thats why I adjusted to accoring to that outcome.
I see a bit of a benefit to get some extra time before people start to vote and maybe make wrong decisions if some context needs to be communicated via other channels. E.g. someone makes a dangerous param change request and some stakeholders want to have time to raise awareness to other stakeholders before they start voting.
Beside that this longer break could be used for a solution to freeze/archive the proposals so in case they got changed in GH the original is still available (still an open issue but not critical for launch IMO).

Re 2:
Fine for me. We can make both blind vote and reveal 3 days.

Re 3:
The 23 value was a mistake. Will fix it to 3 as well.
I want to avoid to over-use the param change framework. I think the min/max should give enough headroom and are already prob. too large. Bigger changes can be done in iterations. The min/max only relates to the current value. So if its 2 you can double up each month.

There will be some additional restrictions not covered ny the min/max like vote threshold cannot be lower than 50% or break phases cannot be reduce to < 6 blocks (reorg risk) and they cannot be negative. Those validations are still WIP and I will work on that soon.

from proposals.

devinbileck avatar devinbileck commented on June 23, 2024
  1. Good point, makes sense.
  2. Sounds good to me.
  3. I agree 3 seems high. 2 (or maybe even 1.5?) does seem more reasonable.

from proposals.

ManfredKarrer avatar ManfredKarrer commented on June 23, 2024

Will wait for a bit more feedback and then change to your suggestions.

from proposals.

sqrrm avatar sqrrm commented on June 23, 2024

Re: 2 I'm also in favor of a longer reveal time.

Otherwise I like these settings, I don't worry too much about the changing of parameters, it will be possible and I don't think these settings will be too far off what we'll want.

from proposals.

ManfredKarrer avatar ManfredKarrer commented on June 23, 2024

Updated durations with 3 days both blind vote and vote reveal phase.

from proposals.

ManfredKarrer avatar ManfredKarrer commented on June 23, 2024

Also reduced min/max factor from 3 to 2 for phase durations.

from proposals.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.