Giter VIP home page Giter VIP logo

Comments (10)

ManfredKarrer avatar ManfredKarrer commented on September 25, 2024 2

I would say lets close that if noboday has further concerns.

from proposals.

ManfredKarrer avatar ManfredKarrer commented on September 25, 2024

Regarding the trade fees:

We keep the current fee if the user prefers to use BTC for the fee payment.
If the user opt in to BSQ fee payment he will pay 10% of the BTC fee with the assumption that 1 BSQ = 1 USD and 1 BTC = 10 000 USD. It could be expressed in BSQ to BTC relation as well but I think that is harder to get a guts feeling for.
It can be assumed (hoped) that the real BSQ market rate will be higher which will make that difference between BSQ and BTC fee smaller. This is intended as we want to fade out or at least reduce the BSQ discount over time. It will likely be required that we adjust the BSQ fee and probably the BTC fee as well. Increasing the BTC fee over time is an option as well to get again a better discount. Mid term target is that > 75% of our traders use BSQ and the actual revenue from fees is similar to todays fee (0.2%).

But of course the fee policy will be then in the hand of the BSQ stakeholders.

from proposals.

ManfredKarrer avatar ManfredKarrer commented on September 25, 2024

@Cypherspace86 will work on the verification task (bisq-network/bisq#1769).

from proposals.

devinbileck avatar devinbileck commented on September 25, 2024

Some of those comments in the above code snippet need to be updated based on recent changes to amounts and data types.
Also, the min/max increase values may need to be adjusted. They seem high for most parameters.
Otherwise, the values look good to me.

from proposals.

ripcurlx avatar ripcurlx commented on September 25, 2024

Also, the min/max increase values may need to be adjusted. They seem high for most parameters.

@devinbileck I don't see them in this list?

Agree to update the comments. I also think it would be good to display in the UI values that are based on 1 BTC trade volume in percent to make it easier to understand.

from proposals.

sqrrm avatar sqrrm commented on September 25, 2024

I think the parameters look good.

@devinbileck I think it's good to have some leeway to change the parameters in the beginning, we might be totally off with some of them and need to change them significantly. The risk of allowing too much of a change doesn't seem big to me as there is still voting with a high threshold to change anything.

from proposals.

devinbileck avatar devinbileck commented on September 25, 2024

I don't see them in this list?

@ripcurlx They are the 3rd and 4th arguments for each of the parameters in the code snippet above (not in the code snippet of the original comment to this issue).

I think it's good to have some leeway to change the parameters in the beginning, we might be totally off with some of them and need to change them significantly. The risk of allowing too much of a change doesn't seem big to me as there is still voting with a high threshold to change anything.

@sqrrm Good point.

from proposals.

ManfredKarrer avatar ManfredKarrer commented on September 25, 2024

I updated the list above and removed the second entry with the updated list....
Fixed the comments in the fee section.

from proposals.

 avatar commented on September 25, 2024

The values look also ok I think.
Anyway, if I understand well, if there is need to adapt, those values can be changed by a vote from the contributors (?)

from proposals.

ripcurlx avatar ripcurlx commented on September 25, 2024

The values look also ok I think.
Anyway, if I understand well, if there is need to adapt, those values can be changed by a vote from the contributors (?)

Yes.

from proposals.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.