TypeError when adding a product to wishlist without a referer about syliuswishlistplugin HOT 3 OPEN

Hi @jurv,
Could you describe some real-life situation, when this becomes an issue? I guess somebody would rather want to check the product first instead of adding it to wishlist instantly, especially when action is being performed not completely intentional.

I'd suggest, that sending URL performing action on users wishlist might not be well perceived by customer but maybe your case is different.

from syliuswishlistplugin.

Well, the two cases I gave are real-life situations that we encountered in the last shop we deployed with this plugin :

• bots : they are flooding our error logs.
• users sharing the "Add to wishlist" links. I admit it's a weird case, but it actually happened.

You made a good point regarding the fact that performing an action on the wishlist without the user consent might not be well perceived. I didn't think of that. But I guess that made me question the behaviour of this controller even more 😅 Shouldn't this action only be accessible through a POST request then ? And a GET could redirect to the refered product's page, so that as you said the user could check out the product and not have it automatically added to his wishlist without maybe realising it ?

from syliuswishlistplugin.

Hi,
I think that redirection is better, user-friendly approach. Would you mind providing a PR?

from syliuswishlistplugin.