Comments (12)
It might make sense to show no icon at all if there's no Tor connection.
When we do show an icon, I suggest only showing that when the connection is actually secure:
- all outbound connections go through Tor; and
- inbound connections are disabled, or are through Tor
In particular, there's not much privacy benefit in connecting to some nodes via Tor and some nodes via plain internet.
This approach makes the "connecting" icon unnecessary, because we already have an indicator for connectivity in general.
from gui.
Concept ACK
from gui.
Nice!
from gui.
I like the minimalism, I think that is important for Core. The "Not connected" icon and "connected" icons are clear. Maybe the "connecting" icon could be fainter. Similar to the "Not connected icon" but without the cross.
from gui.
Why not pick the icons that look good even when scaled down (non high-DPI displays)?
Tor made an effort and recently changed those: https://trac.torproject.org/projects/tor/ticket/25702
from gui.
Why not pick the icons that look good even when scaled down (non high-DPI displays)?
SVG will look fine when scaled down or up
from gui.
When rendering an SVG, there will always be a limit until it can no longer be scaled down and still be distinguished from a blurry blob. Generally, the less detail an SVG has, the less pixels are needed to still represent the details.
from gui.
I'll look at what Tor has done, can always have different icon sizes in the repo - the ones I uploaded in my PR are 128 x 128 same as the other icons use in the bottom menu.
from gui.
Should we distinguish "node has a Tor network connection" and "node has only Tor network connection"?
The former could lead an unexperienced user to a false sense of privacy.
Also "listening to Tor" (inbound connections) and "connecting to Tor" (outbound connections) are controlled by different options, and it means there are 4 different states of the node. I think Tor icons should cope them all, no?
from gui.
New designs using only one icon based on feedback. If the icon is clicked the user should be re-directed to the 'Network' tab in settings -> options.
If the user is connecting through a Tor proxy (and not a IPv4 or IPv4 one) should the proxy 'P' icon in the bottom right be shown still? Based on my understanding I think not but am not sure if they have separate technical reasons for showing both.
Figma source files for icon
Figma source files for designs
from gui.
@Bosch-0 @Sjors Please review bitcoin/bitcoin#19926
from gui.
@Bosch-0 @Sjors Please review bitcoin/bitcoin#19926
The PR has been moved into this repo: #86.
from gui.
Related Issues (20)
- Send: ability to (re)view automatically selected coins
- macOS qt QTimer::stop crash on v26.0rc2
- The logo icon doesn't show properly under Wayland HOT 2
- Weird focus rect displayed on inital sync HOT 4
- "Open bitcoin URI" dialog could give more feedback on what's wrong with BIP21 URI
- New crash in v26.0 HOT 7
- How to get started with Contribution HOT 5
- I don't think we should add a lock icon or something like that; there are significant benefits of having encrypted connections on a large scale, but users in general shouldn't assume that their specific connections are more secure for their specific purposes when they're v2.
- ci_native_asan: UndefinedBehaviorSanitizer: null-pointer-use qt/test/wallettests.cpp:424:25 in HOT 5
- When selecting a custom data directory on first launch of Bitcoin Core GUI on Mac, where is that setting stored? HOT 4
- test: `migrateSettings` fails on Windows HOT 1
- Segfault in qt/clientmodel.cpp:92 on every shutdown HOT 5
- Bitcoin core UI is unresponsive while syncing HOT 8
- implicit-integer-sign-change wallet/interfaces.cpp:289:57 HOT 13
- gui: node shutting down after incorrect proxy IP address input HOT 7
- Create unsigned when increasing fee asks for the passphrase HOT 6
- A config option to separately store blocks and state in start window
- Welcome screen uses GiB values as GB, risking running out of space HOT 2
- Generalized fee bumping HOT 1
- Bugreport HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gui.