Comments (6)
Compile from source MinGW64, run twice..
What are the exact steps to reproduce, including the exact operating system version?
Does it happen with the compiled release version as well?
Ref: https://en.cppreference.com/w/cpp/filesystem/remove
from bitcoin.
Windows 10. I run the official binary on Linux and that's fine. Different compilers seem to manage the exception slightly differently? Regardless I'm not sure that a blind delete is the right way to do this, is all. Fixed on my side, I just wanted to point it out.
from bitcoin.
Different compilers seem to manage the exception slightly differently?
That should not be the case. The point of standard C++ library std::filesystem::remove
is to provide the same interface behavior, regardless of compiler or operating system.
The specification says that false
should be returned when the file does not exist, not an exception be thrown.
However, without exact steps to reproduce, using your compiler version, there is little that can be done here.
Regardless I'm not sure that a blind delete is the right way to do this, is all.
Right, it could make sense to catch the exception for other reasons, or not allow it to be thrown, but that is a different question.
from bitcoin.
According to #29930 (comment) the reason could be that you are using an experimental C++17 standard library, which has bugs?
from bitcoin.
That should not be the case. The point of standard C++ library
std::filesystem::remove
is to provide the same interface behavior, regardless of compiler or operating system.The specification says that
false
should be returned when the file does not exist, not an exception be thrown.
Ah good point ><. I'll try it once with my clang install, it's a fair bit newer than my gcc which is due to be updated anyway. Ok to close from my side. Thanks.
from bitcoin.
Closing for now, but please leave a comment if there are more details to debug this issue.
from bitcoin.
Related Issues (20)
- Add "maxuploadtargettimeframe" to change the timeframe considered by "maxuploadtarget"
- show error "could not sign any more inputs" when sign PSBT for multisig
- .
- "bitcoin-cli" does not exist, while "bitcoind" does in ~/bitcoin/src folder HOT 4
- bitcoin-cli hanging on RPC in an empty datadir HOT 1
- .
- Where is the bitcoin.conf file located? HOT 4
- VM disk for OS (Debian 12.x) gets smaller and smaller - NOT the same disk i used for .bitdoin data directory which is mounted on another disk HOT 12
- build: make macOS build Clang only
- Make Transport independent of CNetMessage and CSerializedNetMsg HOT 6
- build: use UCRT runtime for Windows (release) binaries
- Improve/simplify node sync for pruned nodes HOT 6
- Improve/simplify node sync for pruned nodes HOT 2
- .
- fuzz: timeout/oom in package_rbf HOT 1
- fuzz: wallet_bdb_parser: implicit-signed-integer-truncation wallet/migrate.cpp:554:35 HOT 1
- Erlay Project Tracking
- fuzz: crypter: Abrt in __cxxabiv1::failed_throw HOT 1
- Add bitcoind and bitcoin-cli to macOS release HOT 3
- Won't compile with miniupnpc 2.2.8 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitcoin.