guix: SOURCE_DATE_EPOCH is already set in some environments about bitcoin HOT 5 OPEN

• Rename our SOURCE_DATE_EPOCH to something non-standard that doesn't conflict with Nix.

As we run Guix shell in a container, it seems reasonable to rename SOURCE_DATE_EPOCH in the guix-build and guix-codesign scripts, and pass it to the container using its original name:

--env SOURCE_DATE_EPOCH="${BITCOIN_SOURCE_DATE_EPOCH:?unable to determine value}"

from bitcoin.

Sounds good to me. I think it's fine to rename it, I think there's really very few edge cases in which one would really want to pass in a custom epoch to the guix build?

from bitcoin.

As we run Guix shell in a container, it seems reasonable to rename SOURCE_DATE_EPOCH in the guix-build and guix-codesign scripts, and pass it to the container using its original name:

Not sure. We already have FORCE_DIRTY_WORKTREE. Seems fine to just make SOURCE_DATE_EPOCH function in the same way, rather than new variables / more build options / things being less-standard.

from bitcoin.

That sounds like a good approach to me too. So, fail when SOURCE_DATE_EPOCH is set, unless FORCE_SOURCE_DATE_EPOCH is also set?

from bitcoin.

Or could cover SOURCE_DATE_EPOCH being set under FORCE_DIRTY_WORKTREE, it's not strictly the same, but it's also an intentionally introduced mismatch, and would avoid adding another build option.

from bitcoin.