Comments (4)
I think might be a GCC bug, I can't figure out what is actually wrong with this code that would trigger the warning.
from bitcoin.
Looks like it derives that .begin()
is the same as .end()
which would bring the size to -1
. This would require CPubKey::GetLen
to return 0, which is possible if the first byte is invalid. Maybe it'd make sense to make it return 1
in that case because there's always the first byte?
from bitcoin.
Looks like it derives that
.begin()
is the same as.end()
which would bring the size to-1
. This would requireCPubKey::GetLen
to return 0, which is possible if the first byte is invalid. Maybe it'd make sense to make it return1
in that case because there's always the first byte?
That worked, but since CPubKey
is used in a ton of places, I'm a little bit hesitant to change GetLen
since that may have unexpected side effects. However, I do have a fix that seems to work that changes to using insert()
instead of std::fill
.
from bitcoin.
Yes, could also handle it at another level, though it's strange for a class to return begin()==end()
when there's actually one byte in it.
Edit: but yes it's too risky to change this just to work around a compiler warning in the tests.
from bitcoin.
Related Issues (20)
- LevelDB read failure: Corruption: block checksum mismatch HOT 17
- prune shall not delete blocks it did not download HOT 3
- "netinfo" doesn't show IPv6 "Local addresses" HOT 4
- fuzz, wallet_bdb_parser: BDB builtin encryption is not supported
- descriptor: Tapscript-specific Miniscript key serialization / parsing leads to fuzz timeouts
- .
- Enable `importprivkey`, `addmultisigaddress` in descriptor wallets HOT 2
- Add "maxuploadtargettimeframe" to change the timeframe considered by "maxuploadtarget"
- show error "could not sign any more inputs" when sign PSBT for multisig
- .
- "bitcoin-cli" does not exist, while "bitcoind" does in ~/bitcoin/src folder HOT 4
- bitcoin-cli hanging on RPC in an empty datadir HOT 1
- .
- Where is the bitcoin.conf file located? HOT 4
- VM disk for OS (Debian 12.x) gets smaller and smaller - NOT the same disk i used for .bitdoin data directory which is mounted on another disk HOT 12
- build: make macOS build Clang only
- Make Transport independent of CNetMessage and CSerializedNetMsg HOT 6
- build: use UCRT runtime for Windows (release) binaries
- Improve/simplify node sync for pruned nodes HOT 6
- Improve/simplify node sync for pruned nodes HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitcoin.