Understanding the BIP32 version about bip32 HOT 3 CLOSED

version !== network.bip32.private = "If version is not the private version."
&& = "and"
version !== network.bip32.public = "If version is not the public version."

In order words: "If version is not the public nor private version." which is correct.

The if statement later on is saying "If version IS the private version."

Are you trying to decode a Ypub or Zpub instead of an xpub? The default versions only support extended keys that start with xpub (public) and xprv (private)

from bip32.

of course! thanks!

from bip32.

@junderw I didn't want to open a new issue for this since there are many already on the subject.

It seems there's a nice way to pass in the correct version bytes. It could be really nice if bip32 included this function (maybe renamed to something better), since it's bip32 that consumes the output (rather than include it in bitcoinjs-lib). Let me know if you'd like me to open a PR. It does rely on bitcoinjs-lib's Network type, so, I think it could be best to place this code into a "contrib" directory, in order to avoid adding a dependency. It was really a pain getting to this point so I'm sure others would appreciate it...

// Thank you https://github.com/bitcoinjs/bitcoinjs-lib/issues/1238#issuecomment-426880691
const fixNetworkVersionBytes = (xkey: string, network: bitcoin.Network): string => {
  let type = undefined;
  if (xkey.slice(1, 4) == "prv") type = "private";
  if (xkey.slice(1, 4) == "pub") type = "public";
  if (type === undefined) throw new Error("Bad xkey prefix");

  let data = b58.decode(xkey);
  data = data.slice(4);
  data = Buffer.concat([Buffer.from(network.bip32[type].toString(16).padStart(8, '0'),'hex'), data]);
  return b58.encode(data);
};

from bip32.