Add addressPrefix parameter, merging with progressCallback, scryptParams and network into options argument about bip38 HOT 11 CLOSED

These seems solid now that I think about it. What about moving compressed to options as well? This really simplifies things especially if we have sane defaults IMHO.

from bip38.

@youssefgh yes, this would solve your problem. If this feature were developed, you would just have to pass addressPrefix: 0x6F and you'd be fine for the testnet. I'd appreciate an options parameter a lot 💪

from bip38.

I'm indifferent... but why?

from bip38.

They are rarely used positional arguments, and we don't actually have an addressPrefix argument at the moment.

from bip38.

Someone else can re-open this if they need it - I don't have the time to follow up, and the API is great as is 👍

from bip38.

@jprichardson agreed, compressed by default 👍

from bip38.

Is this supposed to add network to params ? because right now decrypting a testnet encrypted key result in an error
Thinks for your efforts ! you rock guys 👍

from bip38.

What is the status on this?

CryptoCoinJS did implement a .version field that supported specifying the required network details, while BitcoinJS does not support alternative networks.

Is there a way to get hold of the old CryptoCoinJS repo?

Example from this URL:
http://cryptocoinjs.com/modules/currency/bip38/

var bip38 = new Bip38();
bip38.version = {private: 0x80, public: 0x0};

There is no such support in BitcoinJS bip38?

from bip38.

I made an implementation using function parameter, as oppose to the old 1.4.0 version which had a version field on the object instance. Please review, and it should close this issue.

from bip38.

bc1qchl0dursnqqjwzma38kqfkhumtju5jjnzqwgx4

from bip38.

Re: AddressPrefix, I think no. My reasoning is here: #44 (comment)

Re: switching from positional to an opts object argument I am for. It would be a breaking change.

However, at this point since BIP38 is discouraged for use by most core devs, This library is mostly here for legacy purposes.

I will go ahead and close this issue.

from bip38.