Comments (3)
Sure, I'll try to send in a PR in of the coming days 🙂
Yesterday evening I also quickly tested with the develop branch of https://github.com/PHPCompatibility/PHPCompatibility the code of this package, to check for other incompatibilities with PHP 8.2 and it was only those two syntax things it found. So I think it's going to be easy to introduce support for PHP 8.2 (and Magento 2.4.6).
from phpstan-magento.
Thanks for opening the issue. The "incompatibility" is coming from Magento 2.4.6-beta1 and trying to use our extension, right?
So far my goal was to use the exact same version constraints as Magento core to "minimize" the risk of dependency problems. If the latest version broadens the version scope of the laminas/laminas-code
, I guess it is fine to switch the constraint to ^4.5
. So far, I was not running into issues with laminas/laminas-code
in the different versions, their public API seems to be stable. It is "just" the internal functionality that was changed to adapt to the different PHP versions.
I wasn't aware that ${var}
is not a valid syntax anymore. Since laminas/laminas-code
got introduced by the PR regarding the extension attributes, I had in mind to change the code generation in all other autoloaders also but I just did not find the time yet to do that. Any chance you could help out? Would be nice to have the extension compatible with 2.4.6 once it gets released.
from phpstan-magento.
Very much appreciated! If you need help or you have questions, let me know.
from phpstan-magento.
Related Issues (20)
- Missing check when using factory constant HOT 1
- No coverage data is *not* sent to Coveralls
- Certain CI steps run several times without additional result HOT 1
- Move stubs out of src/ HOT 6
- DateTimeFactory Issue; HOT 6
- Use Magento root for TestFrameworkAutoloader HOT 8
- Project config file at path app/code/Vendor/Module does not exist. HOT 5
- Factory generation misnames output class HOT 4
- Current release version not updated HOT 5
- Wrong directory used as "magentoRoot" when current working direcory is not magento root HOT 2
- private string $magentoRoot; not work in PHP 7.2 HOT 4
- Generated class ProductExtension is passed on incorrectly to phpstan HOT 30
- Missing Interface class HOT 9
- Compatibility with PHPstan 1.10.x HOT 4
- Failure with `phpstan/phpstan-phpunit` and PHPStan cache usage HOT 19
- Version 0.30.0 fails with errors about unexpected items in parameters HOT 4
- Extend ci_neon_lint script to validate parametersSchema
- Incompatibility with phpstan & rector and 2.4.6 HOT 1
- Internal error: Class\Foo does not exist and has no extension interface in file class.php HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpstan-magento.