Giter VIP home page Giter VIP logo

Comments (3)

hostep avatar hostep commented on July 24, 2024 1

Sure, I'll try to send in a PR in of the coming days 🙂

Yesterday evening I also quickly tested with the develop branch of https://github.com/PHPCompatibility/PHPCompatibility the code of this package, to check for other incompatibilities with PHP 8.2 and it was only those two syntax things it found. So I think it's going to be easy to introduce support for PHP 8.2 (and Magento 2.4.6).

from phpstan-magento.

shochdoerfer avatar shochdoerfer commented on July 24, 2024

Thanks for opening the issue. The "incompatibility" is coming from Magento 2.4.6-beta1 and trying to use our extension, right?

So far my goal was to use the exact same version constraints as Magento core to "minimize" the risk of dependency problems. If the latest version broadens the version scope of the laminas/laminas-code, I guess it is fine to switch the constraint to ^4.5. So far, I was not running into issues with laminas/laminas-code in the different versions, their public API seems to be stable. It is "just" the internal functionality that was changed to adapt to the different PHP versions.

I wasn't aware that ${var} is not a valid syntax anymore. Since laminas/laminas-code got introduced by the PR regarding the extension attributes, I had in mind to change the code generation in all other autoloaders also but I just did not find the time yet to do that. Any chance you could help out? Would be nice to have the extension compatible with 2.4.6 once it gets released.

from phpstan-magento.

shochdoerfer avatar shochdoerfer commented on July 24, 2024

Very much appreciated! If you need help or you have questions, let me know.

from phpstan-magento.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.