the bitextor.sh script problem : if [ $(echo $line | grep '\s' | wc -l) -eq 0 ]; about bitextor HOT 4 CLOSED

The string "url " does not match the if sentence. If you test this in bash it will return 1:

echo "url " | grep '\s' | wc -l

I think the "if" is working as intended (but it could be coded in a better way).

from bitextor.

The command you provided return 1, that is to say it matches; in other words, it indicate that the "url " contains the '\s' character (Null character) and the grep command can find it and have one return ; and in line 888 of the bitextor.sh script, the logical meaing is : if the command $(echo $line | grep '\s' | wc -l) return 0, that means the $line doesn't meet the correct format（In other words, if it return 1,that is to say it meet the correct format, but "url " isn't the correct format but it also will return 1）.

from bitextor.

The example "url " has a correct format. The expression matches because the format is the one we expect: data TAB data. I agree with you that data in the fields are not right, because the second field is empty in our example (field 1: url, fields 2: "". But we are not checking the fields data here, we are only checking format, and, again, the format is correct, so the 'if' works as intended.

If you are worried about the fields content, I want you to know that they are checked and managed in the Python scrips, raising exceptions if a path or URL is not right. Again, in our example, it will raise an exception saying that the ETT is empty or not found.

Thanks for your feedback and don't hesitate to ask or make a pull request anytime.

from bitextor.

Oh, I see. Thanks very much.

from bitextor.