Parity Error Check Bug - When D1-mini sends 0x22 for a reread after a parity error the FPGA does not decrement the address by 8. about bf-romulator HOT 3 OPEN

There are a few other typo's and I've noted them below.

In file "diagnostics.v" there is also an error on line 165 where an "=" is used instead of "<="
change line 165, from
parity_byte[parity_counter] = vram_data[0] + vram_data[1] + vram_data[2] + vram_data[3] + vram_data[4] + vram_data[5] + vram_data[6] + vram_data[7];
to :
parity_byte[parity_counter] <= vram_data[0] + vram_data[1] + vram_data[2] + vram_data[3] + vram_data[4] + vram_data[5] + vram_data[6] + vram_data[7];

Some of the other verilog files have similar typo's.

"enable_logic.v"
Extra comma on line 337 can be removed
.q(vram_output),

"spi_flash_reader.v"
Line 180 change
state = TX_IDLE;
to
state <= TX_IDLE;

line 194 from
xfer_state = XFER_IDLE;
to
xfer_state <= XFER_IDLE;

line 218 from
xfer_state = XFER_FLASHREAD_BLOCK;
to
xfer_state <= XFER_FLASHREAD_BLOCK;

line 223 from
xfer_flash_blocks_to_read = xfer_flash_blocks_to_read - 1;
to
xfer_flash_blocks_to_read <= xfer_flash_blocks_to_read - 1;

line 235 from
xfer_flash_blocks_to_read = 2;
to
xfer_flash_blocks_to_read <= 2;

line 348 from
ram_address = ram_address + 1;
to
ram_address <= ram_address + 1;

"simple_ram_dual_clock.v" - line 14 is missing a semi-colon at the end
reg [DATA_WIDTH-1:0] ram [2**ADDR_WIDTH-1:0] // ** is exponentiation

from bf-romulator.

from bf-romulator.

Correction: File "spi_flash_reader.v"

Delete line 223
xfer_flash_blocks_to_read = xfer_flash_blocks_to_read - 1;

Add line between line 290 and 291
xfer_flash_blocks_to_read <= xfer_flash_blocks_to_read - 1;

New line should look like this
XFER_READ_BYTES_DONE:
begin
spi_cs_reg <= 1;
xfer_flash_blocks_to_read <= xfer_flash_blocks_to_read - 1;
xfer_state <= XFER_FLASHREAD_NEXT;
end

Changes have been tested to work with a 24MHz clock on an Apple IIe.

from bf-romulator.