Giter VIP home page Giter VIP logo

Comments (3)

Julusian avatar Julusian commented on June 20, 2024 1

@premultiply yep, there was a stupid mistake in my fix..
This time I've added some unit tests with your test cases, so we know that they are both fixed and happy.

I'll make sure this new fix gets into 3.3.1

from companion.

Julusian avatar Julusian commented on June 20, 2024

Interestingly this worked sometimes. I think the difference is that if the new name was longer, then it would sometimes miss a later variable, depending on how much later it started.
Fixed now though

from companion.

premultiply avatar premultiply commented on June 20, 2024

Mmmmh. It is fixed for two variables now but has the old issue on three variables to be replaced:

$(generic-module:title)\n$(generic-module:model)\n$(generic-module:version)

Should be replaced to $(CX350:title)\n$(CX350:model)\n$(CX350:version) but is rewritten as $(CX350:title)\n$(CX350:model)\n$(generic-module:version) on the button.

from companion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.