Strange behavior offline + online editing about slate-yjs HOT 7 CLOSED

Fixed in slate-yjs 0.1.3

from slate-yjs.

@BitPhinix I tested the demo again, the error repeats exactly the same

from slate-yjs.

Hmm weird, I'll recheck this again asap.

from slate-yjs.

This bug also occurs when you change selected mark at some part of text and refresh page.
And one more bug, i can't select more than 1 mark marks on one line, weird thing...

from slate-yjs.

I took a look at this today and the root cause is the way the split_node operation is translated.

Let's say we have 2 clients with the same state (a paragraph with the text hello world):
{type: "paragraph", children: [{ text: "hello world"}]}

Client 1 performs a split_node operation inside the paragraph with offset 5 this results in the following operations:

• remove text " world" from [0, 0]
• insert new text node containing " world" at [0, 1]

Client 2 simultaneously performs a split_node operation inside the paragraph with offset 6 this results in the following operations:

• remove text "world" from [0, 0]
• insert new text node containing "world" at [0, 1]

If the clients are now synced the remove text operations will be combined and both insert node operations will be applied resulting in both the "word" and " word" text nodes to be inserted. YJs can't know that the new nodes are a result of a split_node operations.

slate-collaborative has the exact same issue cudr/slate-collaborative#29. I'll try to find a solution as soon as I find the time to or just port over the solution of slate-collaborative if they manage to solve it.

from slate-yjs.

Closing this issue because this is the intended behavior. For more details refer to: https://discuss.yjs.dev/t/modeling-slate-split-node-behavior-in-yjs/283/2

from slate-yjs.

This problem will cause PathRef to fail

from slate-yjs.