Giter VIP home page Giter VIP logo

Comments (8)

lukaszaoralek avatar lukaszaoralek commented on July 30, 2024

@awsfanatic
change symbol "DASH" for the currency DASH to "DSH", for example:
CurrencyPair dashBtc = new CurrencyPair("DSH", "USD");

let me know, if does it work for you now

from xchange-stream.

awsfanatic avatar awsfanatic commented on July 30, 2024

@lukaszaoralek
Yes, this works:
val pair = new CurrencyPair("DSH", "USD")

This doesn't:
val pair = CurrencyPair.DASH_BTC

Any walkaround?

from xchange-stream.

lukaszaoralek avatar lukaszaoralek commented on July 30, 2024

@awsfanatic
There is no workaround, the exchange doesn't use symbol "DASH" for DASH currency, but "DSH". You have to use new CurrencyPair("DSH", "USD").

from xchange-stream.

awsfanatic avatar awsfanatic commented on July 30, 2024

@lukaszaoralek But getExchangeSymbols reports DASH/USD, not DSH/USD. So I guess there is some sort of internal conversion/normalization in place.

from xchange-stream.

lukaszaoralek avatar lukaszaoralek commented on July 30, 2024

@awsfanatic please, go to bitfinex dash tradeview page, enable developer tools from your web browser, click on the network tab and ws connection and check it yourself:
{"event":"subscribe","pair":"DSHUSD","channel":"book","prec":"P1","freq":"F0"}

bitfinex uses only 3 characters string for the currency name.

from xchange-stream.

dozd avatar dozd commented on July 30, 2024

@awsfanatic I see your point. getXchangeSymbols are called in Xchange library so I advice create PR or issue there. It won't be hard to fix.

from xchange-stream.

lukaszaoralek avatar lukaszaoralek commented on July 30, 2024

@dozd I'm not sure if is it good idea to change behavior CurrencyPair.DASH_BTC because there are also exists exchanges (such as Poloniex) where they use "DASH" for DASH currency. Therefore you can create new CurrencyPair("DSH", "USD)" manually to solve it.

Sorry, I understand now, you mean change getXchangeSymbols for Bitfinex. I see now :)

from xchange-stream.

dozd avatar dozd commented on July 30, 2024

@lukaszaoralek Yeah, exactly. Metadata for Bitfinex should contain correct CurrencyPair.

from xchange-stream.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.