[5][gibbsfromncis] Exchange: Set Expiration time for orders about bitshares-ui HOT 32 CLOSED

@wmbutler actually timepicker looks like I shit. I've spent few hours to fix it's bugs. I'll replace it for Ant timepicker as soon we integrate ant.

from bitshares-ui.

@gibbsfromncis that looks not so good. Perhaps better use a drop down with 1 minute, 5 minute, 1 hour, 1 day and etc listed, if going this way, it's best if the list is configurable in settings, with some well-picked values as default.

from bitshares-ui.

@gibbsfromncis I was thinking something like the below example. It doesn't interrupt the amounts/totals inputs so much and acts as more of an optional step for those who want it. Putting it within the main form makes it feel like customizing the expiration might affect the total price.

I added a drop down inside the date/time picker to show how we could include preset times per @abitmore suggestion.

from bitshares-ui.

and Market Order

from bitshares-ui.

Most of the time here is for integrating a calendar widget and troubleshooting everything related to this control.

from bitshares-ui.

@wmbutler Where do you think it should be placed? On the confirmation window (We can make it like Propose - add switch custom expiration and if user turns it on I'll display input with date and user be able to change it):

or Buy/Sell order forms (it requires new field and may be not good to load this forms by not so useful field)?

from bitshares-ui.

I think it will need to be a calendar picker on the BUY/SELL controls that gets reflected on the confirmation screen.

from bitshares-ui.

@wmbutler assign to me.

from bitshares-ui.

Added 2 hours. Make sure the calendar widget can be used everywhere. Please propose libraries here before adding.

from bitshares-ui.

@ahdigital UX might be helpful here so @gibbsfromncis can just follow your blueprint.

from bitshares-ui.

I'd be tempted to put it on the modal (I have a nice idea to display it) because:

• Space is at a premium on the order form
• It adds another layer of complexity for less experienced traders

from bitshares-ui.

@ahdigital It's hard to put it on the Modal because on this step (when modal displayed) transaction already created. And on modal window user when user click on approve button he "sign" it instead of create it.

from bitshares-ui.

I see. Not in the modal then!

from bitshares-ui.

@ahdigital do you any ideas how to present it except adding new Expiration field like this:

from bitshares-ui.

Yeah sure. I can post an example in the morning UK time.

from bitshares-ui.

@ahdigital nice! Thank you!

from bitshares-ui.

@abitmore 100% agree. I suppose it should be a dropdown with the following values:

• 1 minute
• 5 minutes
• 1 hour
• 3 hours
• 1 day
• Custom Time (an ability to select specific date/time)

But I don't think it's good to make this small feature so complicated. Lets go by simple way like just one dropdown and if after release a lot of users will ask us to make it configurable - we will do it.

from bitshares-ui.

Please pick a good default value. 1 day is perhaps too short. Current default is 15 years or so.

By the way, OP is very old. I don't even know who want this feature at this moment.

from bitshares-ui.

PR: #1309

from bitshares-ui.

@gibbsfromncis would you mind posting a licecap of this in action? You've been busy!!!

from bitshares-ui.

@wmbutler yes sure

from bitshares-ui.

Really elegant solution. Nicely done!

from bitshares-ui.

Hi guys, any chance we can get the default setting set to a maximum or no expirery as auto removing orders after 30 days will lower liquidity. I think its a good feature i can certainly see the benefits but the default setting should be set to max. :)

from bitshares-ui.

Yes, the expiration drop-down needs a "Never" option and that should be the default since non-expiring orders make the most sense, for the reason stated by @CryptoKong, among others.

Also, unless you have a very good reason to do otherwise, it's always a good rule of thumb to maintain the original default behavior when adding options for a setting that wasn't previously user-configurable...especially when such an unexpected change could actually cost someone money.

P.S. The calendar is getting cut off when the order form is near the bottom of the screen:

from bitshares-ui.

@CryptoKong @tbone-bts thanks guys for your feedback. I've created an issue with changes you ask: #1331

Is it OK if "Never" option will be 10 years?

from bitshares-ui.

@tbone-bts @CryptoKong for overall performance, a limitation on expiration will be enforced in bitshares-core sooner or later. In fact, we can't afford that everyone puts thousands if not millions of never-expire and never-fill orders in the system. On UI, we should encourage people to set an expiration that is not too far away. For better UX, perhaps every account can have 10 orders or so that have longer expiration but certainly not all, although it's a bit too complicated.

from bitshares-ui.

Even this: orders with longer expiration should pay higher fee.

from bitshares-ui.

10 years would be more than enough for a "never" option. Could we set the default to 1 year rather than 30 days? 30 days is far too short in my opinion.

from bitshares-ui.

@CryptoKong you can use the "specific" time, I think it will remember your last input?

from bitshares-ui.

@abitmore actually it doesn't but I suppose it's nice idea

from bitshares-ui.

For modifications, open this as a separate issue. This one is closed.

from bitshares-ui.

This is issue for future discussions #1331

from bitshares-ui.