Giter VIP home page Giter VIP logo

Comments (62)

kspearrin avatar kspearrin commented on July 26, 2024 8

We are out of the queue and in active review. Expect release soon!

from clients.

mhammond avatar mhammond commented on July 26, 2024 6

I'm afraid I don't carry any weight in addons :( I did however raise this in our internal forums and made the exact same point as you - ie, "5 months in review, during which there are 6.5k chrome users of the addon - surely this is hurting us!" and I'll continue to agitate where I can.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024 4

Waiting almost 2 weeks since they "started" the review. I sent an email asking about the status. Their reply:

we are currently going through a surge of submissions, so the review takes longer than usual.
Also, a lot of developers request expedited review, which makes prioritization hard.
We will try to get to yours as soon as we can.

Sorry guys, I thought it would be ready by now..

Queue Position: 7 of 236

from clients.

walrus543 avatar walrus543 commented on July 26, 2024 4

More than 4 months to get it approved... That's a serious issue for Firefox team compared to other browsers.
Thanks for keeping us informed.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024 3

We moved a tick. Queue Position: 4 of 298

from clients.

kspearrin avatar kspearrin commented on July 26, 2024 2

We've hit a bit of a roadblock here. Apparently Mozilla has now banned the use of Angular 1.x outright, which is a core library of our extension. I was not aware of this until just now. I have raised an issue with Mozilla and it is being tracked here: mozilla/addons-linter#1000

Stay tuned.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024 2

Good news. Angular has resolved the issue that has been holding us back. They plan to release v1.5.9 of angular soon. Whenever that happens we will quickly upgrade and re-submit to Mozilla for review.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024 2

As of v1.5.0, we are now in review with Mozilla again. We are working on trying to reduce the wait time of the review process.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024 2

I'm waiting to see how the review process works for updates once we are in the store. I sure hope that we don't have to wait 2 months every time we want to submit an update, especially for things like important hotfixes like you mention.

from clients.

 avatar commented on July 26, 2024 2

Any news about the review process? (I want this addon so bad.) :-)

from clients.

umarmughal avatar umarmughal commented on July 26, 2024 2

Guys when we can expect this extension, what is the current status?

from clients.

mhammond avatar mhammond commented on July 26, 2024 2

@kspearrin I'm confident the issue isn't simply that it hasn't been reviewed, so I took your addon, unzipped it, added:

"applications": {
"gecko": {
"id": "[email protected]",
"strict_min_version": "42.0"
}
},

to manifest.json, re-packed it, and I could install the addon fine. I'm fairly sure that will only work on Nightly and Aurora with the preference xpinstall.signatures.required set to false, but in that environment it's certainly possible to manually install your own unsigned addons and have them work. I suspect about:debugging generates an ID for you (and it may even be possible that the repacked xpi of the signed addon that will end up on addons.mozilla.org will also have an ID assigned for you), but it's certainly true that the lack of the ID in the XPI pointed at above is preventing it from being installed in Nightly and Aurora with the "must be signed" preference set to false..

from clients.

mhammond avatar mhammond commented on July 26, 2024 2

On a current Nightly with xpinstall.signatures.required=false, the addon installs and appears to work fine :)

from clients.

kspearrin avatar kspearrin commented on July 26, 2024 1

I believe that their linter will require an update to block v1.5.9 which means it will require no change on their end and we can resubmit as soon as v1.5.9 lands.

from clients.

walterbe avatar walterbe commented on July 26, 2024 1

When you try to install the version V1.50 (link first posting) you get an error that this extension doe sot work in FF 43 or higher.
Question; is there an version that works in the current FF release? A not yet approved by Mozilla version , a developer version?
The fact there is no working FF extension available to use by the users is not helping the Kickstarter campaign. A version outside the official library is a lot better then no extension.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024 1

Jan 1
98 of 301

from clients.

kspearrin avatar kspearrin commented on July 26, 2024 1

Finally! After 155 days of waiting, the extension has been reviewed by Mozilla and available on Firefox now here: https://addons.mozilla.org/en-US/firefox/addon/bitwarden-password-manager

Thank you all for your patience. I'm sorry it took so long but there wasn't a hole lot we could do differently here.

If you have any problems, please open them as separate issues.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Oct 8th status

Queue Position: 57 of 165

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Oct 11th status

Queue Position: 38 of 145

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Oct 13th status

Queue Position: 20 of 137

from clients.

webjames avatar webjames commented on July 26, 2024

@kspearrin The link in the readme and issue description is now 'not found'.

from clients.

ethanhs avatar ethanhs commented on July 26, 2024

Though it looks like in the linter discussion mozilla is still not satisfied with the checks in v1.5.9...

But it looks like the angular team and Mozilla are working together to resolve it?

from clients.

nogweii avatar nogweii commented on July 26, 2024

I believe that's because Mozilla hasn't signed the add-on since it's still in review? And users in regular versions of Firefox can't disable the code signing check, so bitwarden doesn't have much power here other than to wait for the review to finish. Or convince it's users to use the nightly edition of Firefox, with all of that potential instability.

from clients.

walterbe avatar walterbe commented on July 26, 2024

If that is the reason I understand it. But strange for something like FF there is no setting somewhere, like by means of an about:config setting, to override that. And why can you install it in FF 42? It should be all or nothing.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

As mentioned, Mozilla requires that the extension be reviewed and signed before you can add it from their store. There is nothing we can really do about it. The wait time for their review process on new addons is months. We are in the queue at position 208 of 306 :( .

The only option to use the extension in the meantime is to build the source and add it locally via about:debugging, but that is only temporary and will require you to do it each time you restart the browser. Or use Chrome or Opera :-/.

from clients.

walterbe avatar walterbe commented on July 26, 2024

@kspearrin about Opera;
On the website is the notice that just like with FF the plugin for Opera is waiting for approval by Opera. I do not find a thread about this plugin for Opera here. Where is that not-approved Opera plugin? That can be installed manually on Opera?

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Regarding Opera, we have had our extension in their review queue for 3 months now and there is no response. New addons for Opera seem to be dead since noone is reviewing new submissions there anymore. The good news is that Opera and Chrome Web Store extensions are compatible -- meaning you can install bitwarden from the Chrome web store by using this opera extension: https://addons.opera.com/en/extensions/details/download-chrome-extension-9/

I will need to put together a help article to link to from the homepage Opera icon.

from clients.

Zorroblanco avatar Zorroblanco commented on July 26, 2024

Hi there, I ve installed Bitwarden from Chrome store with this extension https://addons.mozilla.org/en-US/firefox/addon/chrome-store-foxified/?src=search This could a temporaly solution (It`s working fine, but I dont know if exist some problem with security, please check it) Sorry for my english Im spanish guy. Cheers

from clients.

walterbe avatar walterbe commented on July 26, 2024

@Zorroblanco thank you. It is complicated and inconvenient but at least it works. Thanks again.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Dec 22
Queue Position: 163 of 319

from clients.

walrus543 avatar walrus543 commented on July 26, 2024

Then we can expect a review at the end of January...

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Dec 27
Queue Position: 119 of 317

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Dec 30 - 113 of 327

from clients.

MichaelPolla avatar MichaelPolla commented on July 26, 2024

Thanks Kyle for keeping us informed of the Firefox queue progress. Can't wait to use this add-on.
Happy new year !

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Jan 6
88 of 304

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Jan 11
77 of 302

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Jan 16
Queue Position: 62 of 309

from clients.

cipri-tom avatar cipri-tom commented on July 26, 2024

Another extension which I'm using 'bypasses' the Firefox review queues by providing a GreaseMonkey script. Would that be something sensible for you to do, too ? I mean, saying a hotfix is needed and as a user you have to wait until the queue clears, I'd prefer to get an unsigned version on GreaseMonkey, because I have to trust you anyways.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Mozilla started reviewing it over a week ago and then went silent. We're sitting at Queue Position: 11 of 275

Hoping any day now.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Queue Position: 6 of 246

from clients.

jmauss avatar jmauss commented on July 26, 2024

The new betas of Firefox are showing some serious increase in speed... hoping that bitwarden gets approved by their release!

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Queue Position: 5 of 294 :(

from clients.

grafenhofer avatar grafenhofer commented on July 26, 2024

Such a long waiting time does not seem to be that common: https://blog.mozilla.org/addons/2017/02/14/add-ons-update-92

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Mozilla relies heavily on community members to review addons. Apparently since our addon is not a simple one, and contains a lot of code the community reviewers will not review it. Therefore, our addon falls into a bucket of only a select few official Mozilla employees (one that I know of) that review addons. Reviewing addons is not their only job, so we're stuck waiting for them to have some time in order to decide to start reviewing it.

This was the explanation I was given by Mozilla during all my emails to them about this. Sad that we have to wait so long. We're at their mercy at this point :(

from clients.

mhammond avatar mhammond commented on July 26, 2024

I suspect the "is corrupt" message is due to the following log entries I see on current Nightlies:

1487663041974 addons.xpi WARN Download of https://addons.mozilla.org/firefox/downloads/file/594812/bitwarden_free_password_manager-1.9.4-an+fx.xpi?src=dp-btn-primary failed: Error: Cannot find id for addon C:\Users\skip\AppData\Local\Temp\tmp-v8d.xpi (resource://gre/modules/addons/XPIProvider.jsm:5519:19) JS Stack trace: loadManifest/<@XPIProvider.jsm:5519:19 < ....

IIUC, https://github.com/bitwarden/browser/blob/master/src/manifest.json doesn't specify an ID for this addon? It does appear to load from about:debugging though.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

@mhammond The corrupt message is simply because Mozilla hasn't reviewed it yet.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Please refer to the updates above.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

@mhammond According to this: https://wiki.mozilla.org/Add-ons/Extension_Signing

Mozilla now requires all extensions to be signed by Mozilla in order for them to be installable in Release and Beta versions of Firefox. Signing will be done through addons.mozilla.org (AMO) and will be mandatory for all extensions, regardless of where they are hosted.

Firefox 40-42: Firefox warns about signatures but doesn't enforce them.
Firefox 43: Firefox enforces the use of signatures by default, but has a preference that allows signature enforcement to be disabled (xpinstall.signatures.required in about:config).
Firefox 48: (Pushed from Firefox 46). Release and Beta versions of Firefox for Desktop will not allow unsigned extensions to be installed, with no override. Firefox for Android will enforce add-on signing, and will retain a preference — which will be removed in a future release — to allow the user to disable signing enforcement.

Are you saying that this is not necessarily the case?

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

According to the above, xpinstall.signatures.required is not overridable (is that a word?) after Firefox 48. I don't have a problem adding that to the manifest though and we can see if it works?

from clients.

mhammond avatar mhammond commented on July 26, 2024

The above is for the release and beta channels only - Nightly and Aurora (aka Dev Edition) does still allow it. So while that doesn't help the vast majority of users, it probably does help unstick developers and gives an option for your "early adopters".

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Looks like an ID has already been assigned by AMO and I cannot change it at this point (without abandoning my current submission and starting over).

Your add-on failed validation with 1 error.
The add-on ID in your manifest.json or install.rdf ([email protected]) does not match the ID of your add-on on AMO ({xxxxxxxxxxxxxxxxxxxxxxxx})

from clients.

mhammond avatar mhammond commented on July 26, 2024

Can you just use the ID assigned by AMO? I don't think the ID is exposed via any UI, so it doesn't really matter what it is.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Give it a try now from the AMO listing. I don't get the corrupt error anymore, now just a signing error.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

@mhammond Great! I see you are part of the Mozilla Org. Do you happen to pull any weight there in the Firefox addons department? We've been patiently waiting for our extension to be listed since September. This whole process has been painful. I'm a Firefox user myself and I've had to basically abandon it for the past 6 months in favor of Chrome because of this.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

I can't tell you how many emails I get every week about "when will it be available on Firefox?" :-(

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

@Anaithsol please open a separate issue.

from clients.

umarmughal avatar umarmughal commented on July 26, 2024

Finally extension reviewed by Mozilla and available to install but panel is blank if using in "Private Mode" is this only me?

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Additionally, since we're so behind in Firefox now, if you all enjoy the extension there, please consider leaving us a good review in the addons store. It helps a lot!!

from clients.

umarmughal avatar umarmughal commented on July 26, 2024

@kspearrin This won't work in Private Mode?

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

@umarmughal This is due to a bug with Firefox that Mozilla is working on fixing. See here: https://bugzilla.mozilla.org/show_bug.cgi?id=1319452

There's nothing we can do about it at this time.

from clients.

mhammond avatar mhammond commented on July 26, 2024

Note that https://bitwarden.com/ still indicates the addon is in review - it should probably be changed to the AMO link.

from clients.

kspearrin avatar kspearrin commented on July 26, 2024

Fixed in all places exception the web vault. Not ready to do a release there yet.

from clients.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.