Giter VIP home page Giter VIP logo

Comments (3)

bjorn2404 avatar bjorn2404 commented on August 27, 2024

Thanks. Fixed in v2.0.4

from jquery-store-locator-plugin.

bhardy avatar bhardy commented on August 27, 2024

_this.notify(_this.settings.geocodeErrorAlert + status); is appending .ZERO_RESULTS to the error messages. I've removed + status and it appears fine, although I'm not thoroughly testing.

from jquery-store-locator-plugin.

bhardy avatar bhardy commented on August 27, 2024

Also, calling the callbackFunction(null); after it just displays 'Unable to find address' which seems redundant. It also makes error handling difficult because it runs the callback twice. The first instance of the callback reports the error and the second says unable to find. I'm injecting code onto the page like so:

var cb_error = function(error_message_string) {
  $('#bh-sl-address').css('border-color', '#cc4c3f');
  $('#bh-sl-user-location').append('<span class="map-error">'+error_message_string+'</span>');
}

Because the callback is called multiple times I end up with two instances of <span class="map-error">. I can't add $('.map-error').remove(); to the beginning of the function because then the second callback simply removes the first error (leaving the user with just: Unable to find address). If the user does multiple erroneous searches (or just clicks search again) the errors begin to pile up.

I hope that made sense. Long story short I've just commented out callbackFunction(null); and it's working for my purposes.

from jquery-store-locator-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.