Giter VIP home page Giter VIP logo

Comments (20)

Ocramius avatar Ocramius commented on August 16, 2024

Are we sure this isn't somehow a problem of ZfcUser itself then? :\ Will need to reproduce...

from bjyauthorize.

bjyoungblood avatar bjyoungblood commented on August 16, 2024

Can you give us a stack trace?

from bjyauthorize.

jhuet avatar jhuet commented on August 16, 2024

Thanks for your quick answers. You may find the whole stack trace here.

from bjyauthorize.

SocalNick avatar SocalNick commented on August 16, 2024

This is happening because the route stack doesn't set the request uri until onRoute. Should we inject the request uri into the route stack before doing $router->assemble in HybridAuthFactory?

from bjyauthorize.

Ocramius avatar Ocramius commented on August 16, 2024

Thx @SocalNick, now I see where this is happening. What are the services instantiated when zfcuser_auth_service is requested? Not sure about who should fix this, but assembling without a valid router is obviously broken :)

from bjyauthorize.

SocalNick avatar SocalNick commented on August 16, 2024

Hey guys, can you try v1.6.1 of ScnSocialAuth: https://github.com/SocalNick/ScnSocialAuth/tree/1.6.1

from bjyauthorize.

Ocramius avatar Ocramius commented on August 16, 2024

@jhuet ping?

from bjyauthorize.

jhuet avatar jhuet commented on August 16, 2024

Woohoo, it fixed it ! Thanks to you all ! 🍻

from bjyauthorize.

jhuet avatar jhuet commented on August 16, 2024

Okay, i've been a bit too fast on closing that one.

Something else is preventing both modules to work together and it's pretty much related to what @SocalNick found before.

In fact, when ScnSocialAuth is assembling from the router with the home route, it looks like it's making BjyAuthorize's route guard to always retrieve the home route. Thus it checks for a route/home and if it passes redirects to this route, no matter what route we really are on.

from bjyauthorize.

Ocramius avatar Ocramius commented on August 16, 2024

@jhuet assembling doesn't trigger Zend\Mvc\MvcEvent::EVENT_ROUTE... Are you sure about this problem?

from bjyauthorize.

jhuet avatar jhuet commented on August 16, 2024

Commenting out the call to assemble and filling $baseUrl with mine make it work, so i felt like that was the cause.

from bjyauthorize.

Ocramius avatar Ocramius commented on August 16, 2024

@jhuet really weird... no ideas on this topic or why that event is fired...

from bjyauthorize.

SocalNick avatar SocalNick commented on August 16, 2024

@jhuet - I made a fix in 1.6.2 and 1.7.1. But I agree with @Ocramius - assembling should not trigger a route event.

from bjyauthorize.

Ocramius avatar Ocramius commented on August 16, 2024

@jhuet do you have a stack trace?

from bjyauthorize.

jhuet avatar jhuet commented on August 16, 2024

1.7.1 did fix it.

@Ocramius, how would you suggest to have a pertinent stack trace ? I tried throwing an exception late in the code but the stack trace wasn't of much use.

from bjyauthorize.

Ocramius avatar Ocramius commented on August 16, 2024

I just wanted to check what piece of code triggers routing there.

from bjyauthorize.

Ocramius avatar Ocramius commented on August 16, 2024

@jhuet you can also attach a listener to the dispatch.error event

from bjyauthorize.

subtubes-io avatar subtubes-io commented on August 16, 2024

is this issue fixed?

from bjyauthorize.

jhuet avatar jhuet commented on August 16, 2024

It is thanks to last version of ScnSocialAuth.

@Ocramius i couldn't get an interesting stack trace. I'll ping you on IRC one day to see that i guess.

from bjyauthorize.

Ocramius avatar Ocramius commented on August 16, 2024

I'm closing this one. @jhuet if you get anything reproducible, I think this is an issue of Zend\Mvc itself then.

from bjyauthorize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.