Giter VIP home page Giter VIP logo

Comments (3)

bkaankose avatar bkaankose commented on August 15, 2024

Thanks for reporting this.

There are 2 issues in this context:

  • Parsing mail subject
  • Parsing the actual HTML body (meaning that your apostrophes in the actual html body has problems as well.)

You figured out the first one, and it's been fixed in the next release preview 1.3 But the second one is weird, because it only happens when you send mail from Mail for Windows

This message is sent from Outlook Web
image

This message is sent from Mail for Windows
image

Generated HTML body output for the mails sent from MFW (Mail for Windows) by Wino.

<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"/>
<meta name="Generator" content="Microsoft Word 15 (filtered medium)"/>
<style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
.MsoChpDefault
	{mso-style-type:export-only;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="#954F72" style="word-wrap:break-word" oncontextmenu="return false;">
<div class="WordSection1">
<p class="MsoNormal">� � � � ��</p>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<p class="MsoNormal">Sent from <a href="https://go.microsoft.com/fwlink/?LinkId=550986">
Mail</a> for Windows</p>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
</div>
</body>
</html>

There is some encoding problem with this generated body because MFW has no problem parsing the proper html body out of raw mime message.

image

Wino uses this simple HtmlPreviewVisitor from MimeKit to extract html body out of raw mime. Which I believe can be improved with some alternatives later on. At some point in this file, the encoding "Windows-1252" can't resolve apostrophes in the HTML.

This is my analysis for this bug as of today, but I think I will get back to this issue once I finish composing :)

from wino-mail.

bkaankose avatar bkaankose commented on August 15, 2024

For similar issue

jstedfast/MimeKit#717

from wino-mail.

bkaankose avatar bkaankose commented on August 15, 2024

For similar issue

jstedfast/MimeKit#717

Lol actually simple registration of charset fixed the issue
image

I will label this issue 'fixed' and we can close the bug after testing it on preview 1.3. Thanks! @MarcAnt01

from wino-mail.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.